github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2556] [MERGED] [PM-2456] Fix attachment encryption on new cipher item encryption model #51856

New Issue
Closed
opened 2026-05-01 15:33:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:33:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2556
Author: @fedemkr
Created: 6/2/2023
Status: ✅ Merged
Merged: 6/5/2023
Merged by: @fedemkr

Base: feature/PM-115-encryption-update-new-model ← Head: PM-2456-fix-new-cipher-encryption-attachment

📝 Commits (1)

  • b2ccc96 PM-2456 Fix attachment encryption on new cipher item encryption model

📊 Changes

5 files changed (+38 additions, -15 deletions)

View changed files

📝 src/App/Pages/Vault/AttachmentsPageViewModel.cs (+1 -1)
📝 src/Core/Abstractions/ICipherService.cs (+1 -1)
📝 src/Core/Services/CipherService.cs (+6 -5)
📝 test/Core.Test/AutoFixture/Cipher/CipherCustomizations.cs (+24 -2)
📝 test/Core.Test/Services/CipherServiceTests.cs (+6 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix attachment encryption on new cipher item encryption model

Code changes

  • CipherService: Applied new cipher item key encryption to attachments.
  • CipherServiceTests: Updated unit tests and added new customization for CipherView

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2556 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 6/2/2023 **Status:** ✅ Merged **Merged:** 6/5/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/PM-115-encryption-update-new-model` ← **Head:** `PM-2456-fix-new-cipher-encryption-attachment` --- ### 📝 Commits (1) - [`b2ccc96`](https://github.com/bitwarden/android/commit/b2ccc9645177240cc5ce3f1538f8faacaadaeb43) PM-2456 Fix attachment encryption on new cipher item encryption model ### 📊 Changes **5 files changed** (+38 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AttachmentsPageViewModel.cs` (+1 -1) 📝 `src/Core/Abstractions/ICipherService.cs` (+1 -1) 📝 `src/Core/Services/CipherService.cs` (+6 -5) 📝 `test/Core.Test/AutoFixture/Cipher/CipherCustomizations.cs` (+24 -2) 📝 `test/Core.Test/Services/CipherServiceTests.cs` (+6 -6) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix attachment encryption on new cipher item encryption model ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherService:** Applied new cipher item key encryption to attachments. * **CipherServiceTests:** Updated unit tests and added new customization for `CipherView` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:33:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51856
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?