[PR #4752] [MERGED] PM-18314 & PM-18450 Check for Chrome browser 3rd party autofill. #5182

New Issue

2025-11-26T23:55:10-06:00

GiteaMirror commented

2025-11-26 23:55:10 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4752
Author: @dseverns-livefront
Created: 2/20/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-18314-check-for-3p-autofill-chrome

📝 Commits (2)

8e7a9f4 PM-18314 & PM-18450 Add manager to capture if third party chrome autofill is available and enabled and add feature flag for chrome autofill.
548c927 feedbeezy

📊 Changes

17 files changed (+427 additions, -3 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+6 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt (+16 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/di/AutofillModule.kt (+12 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt (+17 -2)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManager.kt (+22 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManagerImpl.kt (+52 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManager.kt (+20 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManagerImpl.kt (+62 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeReleaseChannel.kt (+14 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeThirdPartyAutoFillData.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+2 -0)
📝 app/src/main/res/values/strings_non_localized.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt (+53 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManagerTest.kt (+114 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+6 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+2 -0)

📄 Description

🎟️ Tracking

PM-18314
PM-18450

📔 Objective

Add manager classes to query content provider for chrome autofill information per updated blog post.
Add feature flag that when enabled will read the values from that manager otherwise will provide default vaults.
See https://android-developers.googleblog.com/2025/02/chrome-3p-autofill-services-update.html

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4752 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/20/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-18314-check-for-3p-autofill-chrome` --- ### 📝 Commits (2) - [`8e7a9f4`](https://github.com/bitwarden/android/commit/8e7a9f4ad94a51427b2a37541f3df15850bd25c4) PM-18314 & PM-18450 Add manager to capture if third party chrome autofill is available and enabled and add feature flag for chrome autofill. - [`548c927`](https://github.com/bitwarden/android/commit/548c9277192ab0a9627013f7ab7e4a0eeabbd499) feedbeezy ### 📊 Changes **17 files changed** (+427 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+6 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt` (+16 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/di/AutofillModule.kt` (+12 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt` (+17 -2) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManager.kt` (+22 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManagerImpl.kt` (+52 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManager.kt` (+20 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManagerImpl.kt` (+62 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeReleaseChannel.kt` (+14 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeThirdPartyAutoFillData.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+2 -0) 📝 `app/src/main/res/values/strings_non_localized.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt` (+53 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManagerTest.kt` (+114 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+6 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-18314](https://bitwarden.atlassian.net/browse/PM-18314) [PM-18450](https://bitwarden.atlassian.net/browse/PM-18450)  ## 📔 Objective - Add manager classes to query content provider for chrome autofill information per updated blog post. - Add feature flag that when enabled will read the values from that manager otherwise will provide default vaults. - See https://android-developers.googleblog.com/2025/02/chrome-3p-autofill-services-update.html   ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18314]: https://bitwarden.atlassian.net/browse/PM-18314?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-18450]: https://bitwarden.atlassian.net/browse/PM-18450?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:55:10 -06:00

GiteaMirror closed this issue