github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4750] [MERGED] [PM-15873] Add delay to PTR to remove the spinning wheel #5180

New Issue
Closed
opened 2025-11-26 23:55:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4750
Author: @andrebispo5
Created: 2/19/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @andrebispo5

Base: main ← Head: pm-15873/ptr-ui-glitch

📝 Commits (5)

  • 221d41a PM-15873 Add delay to PTR to remove the spinning wheel when there is not internet connection. Check internet connection on sync click.
  • 5228c9f PM-15873 Add error message to PTR if there is no internet connection
  • f99eae8 Merge branch 'main' into pm-15873/ptr-ui-glitch
  • 87f89e8 PM-15873 Run mutable state outside of coroutine scope. Update tests.
  • 1343b8e PM-15873 Fix with PR suggestions

📊 Changes

2 files changed (+121 additions, -9 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+47 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+74 -3)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15873

📔 Objective

Add delay to PullToRefresh to remove the spinning wheel icon when there is not internet connection. This is a workaround for a know issue: https://issuetracker.google.com/issues/248274004
Check internet connection on sync click and show dialog instead of performing the sync.

📸 Screenshots

https://github.com/user-attachments/assets/3375d2ee-c9b7-49cd-99be-16781d414080

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4750 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 2/19/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-15873/ptr-ui-glitch` --- ### 📝 Commits (5) - [`221d41a`](https://github.com/bitwarden/android/commit/221d41a60e5c83bf877c632eb40f0373b657e907) [PM-15873] Add delay to PTR to remove the spinning wheel when there is not internet connection. Check internet connection on sync click. - [`5228c9f`](https://github.com/bitwarden/android/commit/5228c9f0cc280df488f535af1a4cadd6bc79af94) [PM-15873] Add error message to PTR if there is no internet connection - [`f99eae8`](https://github.com/bitwarden/android/commit/f99eae81dd1cbff5ac742505efd9f6d16d4e6421) Merge branch 'main' into pm-15873/ptr-ui-glitch - [`87f89e8`](https://github.com/bitwarden/android/commit/87f89e8695fe48c4835f1532879bf7bb8571a28e) [PM-15873] Run mutable state outside of coroutine scope. Update tests. - [`1343b8e`](https://github.com/bitwarden/android/commit/1343b8ea4cf96edcb5442cc33b185c156d4067d4) [PM-15873] Fix with PR suggestions ### 📊 Changes **2 files changed** (+121 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+47 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+74 -3) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-15873 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Add delay to `PullToRefresh` to remove the spinning wheel icon when there is not internet connection. This is a workaround for a know issue: https://issuetracker.google.com/issues/248274004 Check internet connection on sync click and show dialog instead of performing the sync. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> https://github.com/user-attachments/assets/3375d2ee-c9b7-49cd-99be-16781d414080 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-15873]: https://bitwarden.atlassian.net/browse/PM-15873?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5180
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?