github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2264] [MERGED] [EC-770] Implement MessagePack on Watch sync #51683

New Issue
Closed
opened 2026-05-01 15:23:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:23:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2264
Author: @fedemkr
Created: 12/26/2022
Status: ✅ Merged
Merged: 3/9/2023
Merged by: @fedemkr

Base: master ← Head: EC-770-msgpack-watch-sync

📝 Commits (10+)

  • fc23231 EC-770 Started implementing MessagePack for the iPhone -> Watch communication
  • ac4db83 Merge branch 'master' into EC-770-msgpack-watch-sync
  • 928fd9d EC-770 Removed Pods and installed MessagePack through SPM
  • 5cb338d EC-770 Implemented MessagePack + Lzfse compression when syncing iPhone -> Watch
  • bd5340b Merged master to EC-770-msgpack-watch-sync
  • 0e92f05 Merge branch 'master' into EC-770-msgpack-watch-sync
  • 4b5f909 EC-770 Added MessagePack as submodule and updated the build to checkout the submodule as well. Also added MessagePack files as reference in the watch project
  • 9a8f509 Merge branch 'master' into EC-770-msgpack-watch-sync
  • b7c9fec EC-770 Updated build
  • 9c6039a Merge branch 'master' into EC-770-msgpack-watch-sync

📊 Changes

21 files changed (+228 additions, -45 deletions)

View changed files

📝 .github/workflows/build.yml (+4 -0)
➕ .gitmodules (+3 -0)
➕ lib/MessagePack (+1 -0)
📝 src/Android/Services/WatchDeviceService.cs (+1 -2)
📝 src/App/App.csproj (+3 -0)
📝 src/App/Services/BaseWatchDeviceService.cs (+15 -4)
📝 src/Core/Core.csproj (+7 -0)
📝 src/Core/Models/View/SimpleCipherView.cs (+21 -1)
📝 src/Core/Models/View/WatchDTO.cs (+20 -0)
📝 src/iOS.Core/Services/WatchDeviceService.cs (+20 -9)
📝 src/iOS.Core/Utilities/WCSessionManager.cs (+3 -3)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+2 -1)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/Models/Cipher.swift (+6 -0)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/Utilities/BWState.swift (+1 -0)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/Utilities/JsonDecoderExtensions.swift (+7 -7)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/ViewModels/BWStateViewModel.swift (+2 -2)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/ViewModels/CipherListViewModel.swift (+3 -0)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/Views/BWStateView.swift (+3 -3)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/Views/CipherListView.swift (+1 -1)
📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/WatchConnectivityManager.swift (+32 -12)

...and 1 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improve iPhone -> Watch communication by implementing MessagePack to have more data sent.

Code changes

  • MessagePack Submodule Added MessagePack as submodule to be used in the watch.
  • build.yaml: Added flag to checkout submodules as well
  • other files: Message pack implementation and byte transformation

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2264 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 12/26/2022 **Status:** ✅ Merged **Merged:** 3/9/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `EC-770-msgpack-watch-sync` --- ### 📝 Commits (10+) - [`fc23231`](https://github.com/bitwarden/android/commit/fc23231eb335501b595e059cff214fd0c20bae48) EC-770 Started implementing MessagePack for the iPhone -> Watch communication - [`ac4db83`](https://github.com/bitwarden/android/commit/ac4db8338985fbf3ba8944bd61ceb96a7a809591) Merge branch 'master' into EC-770-msgpack-watch-sync - [`928fd9d`](https://github.com/bitwarden/android/commit/928fd9dd2c8ddcc9cdf9861cc04d366a6b0a19bd) EC-770 Removed Pods and installed MessagePack through SPM - [`5cb338d`](https://github.com/bitwarden/android/commit/5cb338d67500bab4e57c8598652bafe44498ee7a) EC-770 Implemented MessagePack + Lzfse compression when syncing iPhone -> Watch - [`bd5340b`](https://github.com/bitwarden/android/commit/bd5340b5ab051bf9756834d4c2f6ae5441f129c9) Merged master to EC-770-msgpack-watch-sync - [`0e92f05`](https://github.com/bitwarden/android/commit/0e92f051572c4311d76880c8af5dd289d67226d4) Merge branch 'master' into EC-770-msgpack-watch-sync - [`4b5f909`](https://github.com/bitwarden/android/commit/4b5f9093e9a5cb0a6276086297b69582ed028e7f) EC-770 Added MessagePack as submodule and updated the build to checkout the submodule as well. Also added MessagePack files as reference in the watch project - [`9a8f509`](https://github.com/bitwarden/android/commit/9a8f50929bb0fd96dc528175bdc3043f632b6561) Merge branch 'master' into EC-770-msgpack-watch-sync - [`b7c9fec`](https://github.com/bitwarden/android/commit/b7c9fecd17acbf517a9bbc69dbb3cf32bf3fa057) EC-770 Updated build - [`9c6039a`](https://github.com/bitwarden/android/commit/9c6039a71ef32060f542ba11dbd6b1f467226c40) Merge branch 'master' into EC-770-msgpack-watch-sync ### 📊 Changes **21 files changed** (+228 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+4 -0) ➕ `.gitmodules` (+3 -0) ➕ `lib/MessagePack` (+1 -0) 📝 `src/Android/Services/WatchDeviceService.cs` (+1 -2) 📝 `src/App/App.csproj` (+3 -0) 📝 `src/App/Services/BaseWatchDeviceService.cs` (+15 -4) 📝 `src/Core/Core.csproj` (+7 -0) 📝 `src/Core/Models/View/SimpleCipherView.cs` (+21 -1) 📝 `src/Core/Models/View/WatchDTO.cs` (+20 -0) 📝 `src/iOS.Core/Services/WatchDeviceService.cs` (+20 -9) 📝 `src/iOS.Core/Utilities/WCSessionManager.cs` (+3 -3) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+2 -1) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/Models/Cipher.swift` (+6 -0) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/Utilities/BWState.swift` (+1 -0) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/Utilities/JsonDecoderExtensions.swift` (+7 -7) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/ViewModels/BWStateViewModel.swift` (+2 -2) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/ViewModels/CipherListViewModel.swift` (+3 -0) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/Views/BWStateView.swift` (+3 -3) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/Views/CipherListView.swift` (+1 -1) 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/WatchConnectivityManager.swift` (+32 -12) _...and 1 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Improve iPhone -> Watch communication by implementing MessagePack to have more data sent. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **MessagePack Submodule** Added [MessagePack](https://github.com/bitwarden/MessagePack) as submodule to be used in the watch. * **build.yaml:** Added flag to checkout submodules as well * **other files:** Message pack implementation and byte transformation ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:23:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51683
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?