github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4729] [MERGED] PM-18292 - Update section headers for all items to align with V3 Design #5163

New Issue
Closed
opened 2025-11-26 23:54:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4729
Author: @phil-livefront
Created: 2/17/2025
Status: ✅ Merged
Merged: 2/17/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-18292-update-section-headers-v3-design

📝 Commits (3)

  • babdf08 PM-18292 - Update section headers for all items to align with v3 design
  • 040bf10 fix tests
  • 9ec9164 Merge branch 'main' into phil/PM-18292-update-section-headers-v3-design

📊 Changes

5 files changed (+90 additions, -14 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCardItems.kt (+13 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditIdentityItems.kt (+52 -6)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+14 -1)
📝 app/src/main/res/values/strings.xml (+5 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+6 -6)

📄 Description

🎟️ Tracking

PM-18292

📔 Objective

  • Update section headers for all item types to match the linked V3 designs. These updates will touch Login, Card, Identity, and Secure notes.
  • Changed Who owns this item? title to Owner to match figma designs.

📸 Screenshots

Login

Login

Card

card

Identity

https://github.com/user-attachments/assets/6507a673-45ec-4275-be18-defd0a7d2010

Secure Notes

secure note

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4729 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 2/17/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-18292-update-section-headers-v3-design` --- ### 📝 Commits (3) - [`babdf08`](https://github.com/bitwarden/android/commit/babdf08cb152250f9cde526b38d9584cc890bbce) PM-18292 - Update section headers for all items to align with v3 design - [`040bf10`](https://github.com/bitwarden/android/commit/040bf10a6100802896aaa56f1511692410c00575) fix tests - [`9ec9164`](https://github.com/bitwarden/android/commit/9ec91647b881acd2c446edfef5ea402e9b0e68a5) Merge branch 'main' into phil/PM-18292-update-section-headers-v3-design ### 📊 Changes **5 files changed** (+90 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCardItems.kt` (+13 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditIdentityItems.kt` (+52 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+14 -1) 📝 `app/src/main/res/values/strings.xml` (+5 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+6 -6) </details> ### 📄 Description ## 🎟️ Tracking [PM-18292](https://bitwarden.atlassian.net/browse/PM-18292) ## 📔 Objective - Update section headers for all item types to match the linked V3 designs. These updates will touch Login, Card, Identity, and Secure notes. - Changed `Who owns this item?` title to `Owner` to match figma designs. ## 📸 Screenshots ### Login ![Login](https://github.com/user-attachments/assets/85ea7010-b72b-42ae-ae28-9e07a9ab4a10) ### Card ![card](https://github.com/user-attachments/assets/7551ccb6-aad8-4138-bb75-daa91548810e) ### Identity https://github.com/user-attachments/assets/6507a673-45ec-4275-be18-defd0a7d2010 ### Secure Notes ![secure note](https://github.com/user-attachments/assets/507443e0-ec2e-4166-89cc-530ac80ea45f) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18292]: https://bitwarden.atlassian.net/browse/PM-18292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?