github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4721] [CLOSED] [PM-18261] Added default value for linkedIdType to get my vault loading #5157

New Issue
Closed
opened 2025-11-26 23:54:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4721
Author: @cseufert
Created: 2/13/2025
Status: ❌ Closed

Base: main ← Head: cs-workaround-linked-0

📝 Commits (5)

  • 000ee3c Added default value for linkedIdType to get my vault loading
  • 2e58aec Merge remote-tracking branch 'refs/remotes/origin/main' into fork/cseufert/cs-workaround-linked-0
  • 3bfb08f Handle unknown linked field types and improve validation
  • 5548fe8 Revert item injection
  • d9aad10 Add arg names and create string resource

📊 Changes

5 files changed (+72 additions, -1 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/network/model/LinkedIdTypeJson.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+15 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt (+2 -1)
📝 app/src/main/res/values/strings.xml (+3 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+42 -0)

📄 Description

🎟️ Tracking

This address helpdesk issue #587728

📔 Objective

This patch allows me to load my vault in the >= 2024.12 versions of the Android Mobile App.

This is a POC/Workaround to solve my issue of the vault not loading, however I have no idea how my vault has over 100 records with linkedType = 0.

📸 Screenshots

image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4721 **Author:** [@cseufert](https://github.com/cseufert) **Created:** 2/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cs-workaround-linked-0` --- ### 📝 Commits (5) - [`000ee3c`](https://github.com/bitwarden/android/commit/000ee3ceb93356fbb5288c4b32fc9bab5f4bd04b) Added default value for linkedIdType to get my vault loading - [`2e58aec`](https://github.com/bitwarden/android/commit/2e58aecbc98e69178f8e16d2ad8a76a895533160) Merge remote-tracking branch 'refs/remotes/origin/main' into fork/cseufert/cs-workaround-linked-0 - [`3bfb08f`](https://github.com/bitwarden/android/commit/3bfb08fc522957c4d7518ee60fea4caae8ac354e) Handle unknown linked field types and improve validation - [`5548fe8`](https://github.com/bitwarden/android/commit/5548fe884f5e3d7baf1e937ef0bf4578cd5fe5c3) Revert item injection - [`d9aad10`](https://github.com/bitwarden/android/commit/d9aad103eb68abb407f907c008d5b0f5169ef10d) Add arg names and create string resource ### 📊 Changes **5 files changed** (+72 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/network/model/LinkedIdTypeJson.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+15 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt` (+2 -1) 📝 `app/src/main/res/values/strings.xml` (+3 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+42 -0) </details> ### 📄 Description ## 🎟️ Tracking This address helpdesk issue #587728 ## 📔 Objective This patch allows me to load my vault in the >= 2024.12 versions of the Android Mobile App. This is a POC/Workaround to solve my issue of the vault not loading, however I have no idea how my vault has over 100 records with linkedType = 0. ## 📸 Screenshots <img width="390" alt="image" src="https://github.com/user-attachments/assets/e2e2825b-3037-489f-8ca3-d62ba92a9019" /> <img width="246" alt="image" src="https://github.com/user-attachments/assets/11015410-0a02-4215-8290-8731d33898b3" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?