github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4718] [MERGED] [PM-18050] Remove pin policy #5154

New Issue
Closed
opened 2025-11-26 23:54:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4718
Author: @andrebispo5
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @andrebispo5

Base: main ← Head: pm-18050/remove-pin-policy

📝 Commits (4)

  • 9e5d581 [PM-18050] New policy type
  • 941fdf3 [PM-18050] Hide PIN setting based on policy
  • 10208f1 [PM-18050] Tests to Account Security screen and viewmodel
  • b09f506 [PM-18050] Fix policyManager flow value

📊 Changes

5 files changed (+107 additions, -15 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/network/model/PolicyTypeJson.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt (+15 -13)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt (+33 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt (+23 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt (+30 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18050

📔 Objective

Remove remove unlock with pin policy logic:

  • If policy enabled
    • unlock with pin is ON, then show unlock with pin feature
      • if user toggles it OFF, then hide unlock with pin feature
    • unlock with pin is OFF, then hide unlock with pin feature
    • user logs out, then clear pin values so when logging back in the feature is hidden

📸 Screenshots

Hidden PIN:
image

When policy is enabled and the user turns off PIN, the field is hidden:
https://github.com/user-attachments/assets/991e1cea-ce04-481f-82cf-d90ac796a887

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4718 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-18050/remove-pin-policy` --- ### 📝 Commits (4) - [`9e5d581`](https://github.com/bitwarden/android/commit/9e5d58142096df275a66e025820c2e9a16af5dc1) [PM-18050] New policy type - [`941fdf3`](https://github.com/bitwarden/android/commit/941fdf33a4cfdb0fa045ffeda4d086972f2a43af) [PM-18050] Hide PIN setting based on policy - [`10208f1`](https://github.com/bitwarden/android/commit/10208f11e8bc89eaba15137cae6621f6485e7a0d) [PM-18050] Tests to Account Security screen and viewmodel - [`b09f506`](https://github.com/bitwarden/android/commit/b09f506dae58f796c19024639d21877d3c9c7e25) [PM-18050] Fix policyManager flow value ### 📊 Changes **5 files changed** (+107 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/network/model/PolicyTypeJson.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt` (+15 -13) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt` (+33 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt` (+23 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt` (+30 -2) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-18050 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Remove remove unlock with pin policy logic: - If policy enabled - unlock with pin is ON, then show unlock with pin feature - if user toggles it OFF, then hide unlock with pin feature - unlock with pin is OFF, then hide unlock with pin feature - user logs out, then clear pin values so when logging back in the feature is hidden ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> Hidden PIN: <img width="230" alt="image" src="https://github.com/user-attachments/assets/9d41baae-356f-410e-b086-61d39b842d1f" /> When policy is enabled and the user turns off PIN, the field is hidden: https://github.com/user-attachments/assets/991e1cea-ce04-481f-82cf-d90ac796a887 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?