github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 12:13:43 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4713] [MERGED] PM-18083 Ensure segmented buttons on generator fill entire width evenly. #5151

New Issue
Closed
opened 2025-11-26 23:54:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4713
Author: @dseverns-livefront
Created: 2/11/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-18083-segmented-control-ui-bug

📝 Commits (1)

  • 48fb207 PM-18083 calculate the even width split for exposed items which may not be drawn at the top level of the Segemented row scope

📊 Changes

2 files changed (+42 additions, -8 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/segment/BitwardenSegmentedButton.kt (+24 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+18 -5)

📄 Description

🎟️ Tracking

PM-18083

📔 Objective

  • Fix issue where the segmented buttons were not filling out the full length of the segmented row.
  • This is due to the buttons being wrapped in the CoachMarkHighlights and confirmed if they are wrapped in any other container it does not respect the 1f weights applied internally. Instead we are calculating the total width of the row and then splitting it evenly and applying that width to each button.

📸 Screenshots

BEFORE

https://github.com/user-attachments/assets/a9bbf879-548e-4a95-b99f-943460aa045b

AFTER

https://github.com/user-attachments/assets/c3d0b5b4-19bd-4b06-b05f-0c10d7247f6c

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4713 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/11/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-18083-segmented-control-ui-bug` --- ### 📝 Commits (1) - [`48fb207`](https://github.com/bitwarden/android/commit/48fb2070ebec7e929288e577dc0ec5c3a1de20d5) PM-18083 calculate the even width split for exposed items which may not be drawn at the top level of the Segemented row scope ### 📊 Changes **2 files changed** (+42 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/segment/BitwardenSegmentedButton.kt` (+24 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+18 -5) </details> ### 📄 Description ## 🎟️ Tracking [PM-18083](https://bitwarden.atlassian.net/browse/PM-18083) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Fix issue where the segmented buttons were not filling out the full length of the segmented row. - This is due to the buttons being wrapped in the `CoachMarkHighlights` and confirmed if they are wrapped in any other container it does not respect the `1f` weights applied internally. Instead we are calculating the total width of the row and then splitting it evenly and applying that width to each button. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots **BEFORE** https://github.com/user-attachments/assets/a9bbf879-548e-4a95-b99f-943460aa045b **AFTER** https://github.com/user-attachments/assets/c3d0b5b4-19bd-4b06-b05f-0c10d7247f6c <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18083]: https://bitwarden.atlassian.net/browse/PM-18083?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?