github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1953] [MERGED] [SG-390] Fix for missing org items with single org & personal ownership enabled #51465

New Issue
Closed
opened 2026-05-01 15:09:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:09:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1953
Author: @mpbw2
Created: 6/15/2022
Status: ✅ Merged
Merged: 6/15/2022
Merged by: @mpbw2

Base: master ← Head: bugfix-vaultfilter

📝 Commits (3)

  • ecc0167 fix for missing org items with single org & personal ownership enabled
  • 6b41df0 fix for ui issue with vault filter state change on pull to refresh
  • 39b4597 change singleOrgPolicyApplies to local var

📊 Changes

1 file changed (+13 additions, -7 deletions)

View changed files

📝 src/App/Pages/VaultFilterViewModel.cs (+13 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This fixes an issue where org items were not appearing when the vault filter control was hidden due to the single org and personal ownership policies both being enabled.

Code changes

  • VaultFilterViewModel.cs: Update logic to handle mixed policy variations/changes better on initial load and refresh. A delay is required before setting ShowVaultFilter to properly draw the org name in the vault filter if the filter was previously hidden but now shown after a refresh.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1953 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/15/2022 **Status:** ✅ Merged **Merged:** 6/15/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-vaultfilter` --- ### 📝 Commits (3) - [`ecc0167`](https://github.com/bitwarden/android/commit/ecc0167d0d0e7a439c71262ec8605f73040ac247) fix for missing org items with single org & personal ownership enabled - [`6b41df0`](https://github.com/bitwarden/android/commit/6b41df06cf435a778ce974fa0404dcfdf56b0c60) fix for ui issue with vault filter state change on pull to refresh - [`39b4597`](https://github.com/bitwarden/android/commit/39b4597eb1badb3ea1cfe52739a33b3bbbdafab0) change singleOrgPolicyApplies to local var ### 📊 Changes **1 file changed** (+13 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/VaultFilterViewModel.cs` (+13 -7) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This fixes an issue where org items were not appearing when the vault filter control was hidden due to the single org and personal ownership policies both being enabled. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **VaultFilterViewModel.cs:** Update logic to handle mixed policy variations/changes better on initial load and refresh. A delay is required before setting `ShowVaultFilter` to properly draw the org name in the vault filter if the filter was previously hidden but now shown after a refresh. ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:09:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51465
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?