github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 22:00:42 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4697] [MERGED] PM-17838 - Add help button for authenticator key #5136

New Issue
Closed
opened 2025-11-26 23:54:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4697
Author: @phil-livefront
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-17838-add-help-button-for-authenticator-key

📝 Commits (10+)

  • b21d97c PM-17838 - Add logic to handle multiple tool tips on the add edit login screen and added help button for authenticator key section
  • 94380bb move calculating the size based on focus state within the tooltip let block
  • 75fd1c7 PR comments
  • 836f710 Merge branch 'main' into phil/PM-17838-add-help-button-for-authenticator-key
  • bab8eb8 PR comments
  • 6596dbb add missed doc for new param
  • 866c596 adding test tag
  • 6e073ed adding back focus check and fix lint issue
  • b4189a7 Merge branch 'main' into phil/PM-17838-add-help-button-for-authenticator-key
  • 34c0d94 Merge branch 'main' into phil/PM-17838-add-help-button-for-authenticator-key

📊 Changes

11 files changed (+239 additions, -123 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt (+59 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/text/BitwardenClickableText.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+43 -63)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt (+8 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt (+38 -34)
📝 app/src/main/res/values/strings.xml (+2 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+34 -15)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+13 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreenTest.kt (+13 -6)

📄 Description

🎟️ Tracking

PM-17838

📔 Objective

  • Added a help tooltip to the Authenticator Key section in the “Add Item” form, directing users to this link. This was added to the BitwardenTextField to allow future tooltips to be easily added.
  • Ensured the section always remains visible, even without a code present, but disabled the “Set up authenticator key” button when users cannot add or edit the code.
  • Made the “Authenticator Key” text field readable but non-focusable, preventing any user interaction as per Emily’s confirmation (subject to future updates).
  • Fixed a UI issue in QrCodeScanScreen caused by changes to BitwardenClickableText’s defaultMinSize. Converted the string to an annotated string to maintain consistency with ManualCodeEntryScreen.
  • Added a camera icon to the “Set up authenticator key” button.
  • Added logic to show the foregroundDisabled color when BitwardenClickableText is disabled
  • Removed an incorrect camera icon from the “Check password for data breaches” button above the authenticator key section.

📸 Screenshots

Video

untitled.webm

Disable state

Screenshot_1738777344

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4697 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-17838-add-help-button-for-authenticator-key` --- ### 📝 Commits (10+) - [`b21d97c`](https://github.com/bitwarden/android/commit/b21d97c1190d7c2d365b633476491866f05cd459) PM-17838 - Add logic to handle multiple tool tips on the add edit login screen and added help button for authenticator key section - [`94380bb`](https://github.com/bitwarden/android/commit/94380bb17c4e68718ba0a3f374d9a57137f8dc49) move calculating the size based on focus state within the tooltip let block - [`75fd1c7`](https://github.com/bitwarden/android/commit/75fd1c7b08125438a31ce45f1ac78c8f32678112) PR comments - [`836f710`](https://github.com/bitwarden/android/commit/836f7105048fa37c36ba30a81666d19c1a65fb3c) Merge branch 'main' into phil/PM-17838-add-help-button-for-authenticator-key - [`bab8eb8`](https://github.com/bitwarden/android/commit/bab8eb8de06a0ca2517de7daa759a86435460695) PR comments - [`6596dbb`](https://github.com/bitwarden/android/commit/6596dbb9dc960dc6d925387dcb22affc034b78d6) add missed doc for new param - [`866c596`](https://github.com/bitwarden/android/commit/866c59692500eb13a30e58ce309998f14d124c29) adding test tag - [`6e073ed`](https://github.com/bitwarden/android/commit/6e073eddadc0248707c91fa01aabbf1ff0841980) adding back focus check and fix lint issue - [`b4189a7`](https://github.com/bitwarden/android/commit/b4189a771407238ae1a397e268573fb7f3394a71) Merge branch 'main' into phil/PM-17838-add-help-button-for-authenticator-key - [`34c0d94`](https://github.com/bitwarden/android/commit/34c0d94d9ebf92d8a069114855495e9a52c0163b) Merge branch 'main' into phil/PM-17838-add-help-button-for-authenticator-key ### 📊 Changes **11 files changed** (+239 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt` (+59 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/text/BitwardenClickableText.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+43 -63) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt` (+8 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt` (+38 -34) 📝 `app/src/main/res/values/strings.xml` (+2 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+34 -15) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+13 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreenTest.kt` (+13 -6) </details> ### 📄 Description ## 🎟️ Tracking [PM-17838](https://bitwarden.atlassian.net/browse/PM-17838) ## 📔 Objective - Added a help tooltip to the Authenticator Key section in the “Add Item” form, directing users to this [link](https://bitwarden.com/help/integrated-authenticator/). This was added to the `BitwardenTextField` to allow future tooltips to be easily added. - Ensured the section always remains visible, even without a code present, but disabled the “Set up authenticator key” button when users cannot add or edit the code. - Made the “Authenticator Key” text field readable but non-focusable, preventing any user interaction as per Emily’s confirmation (subject to future updates). - Fixed a UI issue in `QrCodeScanScreen` caused by changes to BitwardenClickableText’s defaultMinSize. Converted the string to an annotated string to maintain consistency with ManualCodeEntryScreen. - Added a camera icon to the “Set up authenticator key” button. - Added logic to show the `foregroundDisabled ` color when `BitwardenClickableText` is disabled - Removed an incorrect camera icon from the “Check password for data breaches” button above the authenticator key section. ## 📸 Screenshots ### Video [untitled.webm](https://github.com/user-attachments/assets/9aaff7e3-9606-4063-b224-940ec6c0c80d) ### Disable state ![Screenshot_1738777344](https://github.com/user-attachments/assets/b2930932-6acf-44e2-aa13-0e5a3563dc17) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17838]: https://bitwarden.atlassian.net/browse/PM-17838?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5136
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?