github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1722] [MERGED] Check for disable save prompt option before sending fill request in Android Autofill #51288

New Issue
Closed
opened 2026-05-01 14:58:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 14:58:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1722
Author: @jlf0dev
Created: 1/18/2022
Status: ✅ Merged
Merged: 1/20/2022
Merged by: @jlf0dev

Base: master ← Head: bug/android-save-prompt-issues

📝 Commits (3)

  • 8996803 Check for disable save prompt option before sending fill request
  • af31f01 Add exception handling to Autofill Service
  • 4b235a7 move System reference outside of FDROID

📊 Changes

2 files changed (+115 additions, -89 deletions)

View changed files

📝 src/Android/Autofill/AutofillHelpers.cs (+2 -3)
📝 src/Android/Autofill/AutofillService.cs (+113 -86)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

closes #1017
Asana: https://app.asana.com/0/1169444489336079/1185097609703843/f

We're having reports of some applications and browsers repeatedly asking if the user would like to save login information. While this is most likely an issue with the Autofill service or the application itself, our option to "Disable Save Prompts" isn't working correctly to stop all prompts.

This change moves the check for "Disable Save Prompts" to before sending the fill package. That way, we can determine if the we need to include Save Information in the FillResponse before the prompt shows.

Code changes

  • file.ext: Description of what was changed and why
  • src/Android/Autofill/AutofillHelpers.cs: Change BuildFillResponse to CreateFillResponse as we are only returning the FillResponse.Builder now in order to add save info later on.
  • src/Android/Autofill/AutofillService.cs: Move AddSaveInfo call to the AutofillService as we now check the DisableSavePrompts before calling it.

Screenshots

Testing requirements

  • Testing around Android Autofill Service and the "Disable Save Prompts" option
    • When enabled, there shouldn't be a prompt to save the login

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1722 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 1/18/2022 **Status:** ✅ Merged **Merged:** 1/20/2022 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/android-save-prompt-issues` --- ### 📝 Commits (3) - [`8996803`](https://github.com/bitwarden/android/commit/89968036fe08440bab11b1f67e984caea6117b7e) Check for disable save prompt option before sending fill request - [`af31f01`](https://github.com/bitwarden/android/commit/af31f010205458e57d4b03751434cadee9adfabb) Add exception handling to Autofill Service - [`4b235a7`](https://github.com/bitwarden/android/commit/4b235a7c91fcf8fd6c4ade7cdc8b56fb739835ad) move System reference outside of FDROID ### 📊 Changes **2 files changed** (+115 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/AutofillHelpers.cs` (+2 -3) 📝 `src/Android/Autofill/AutofillService.cs` (+113 -86) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> closes #1017 Asana: https://app.asana.com/0/1169444489336079/1185097609703843/f We're having reports of some applications and browsers repeatedly asking if the user would like to save login information. While this is most likely an issue with the Autofill service or the application itself, our option to "Disable Save Prompts" isn't working correctly to stop all prompts. This change moves the check for "Disable Save Prompts" to before sending the fill package. That way, we can determine if the we need to include Save Information in the `FillResponse` before the prompt shows. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why * **src/Android/Autofill/AutofillHelpers.cs:** Change `BuildFillResponse` to `CreateFillResponse` as we are only returning the `FillResponse.Builder` now in order to add save info later on. * **src/Android/Autofill/AutofillService.cs:** Move `AddSaveInfo` call to the `AutofillService` as we now check the DisableSavePrompts before calling it. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - Testing around Android Autofill Service and the "Disable Save Prompts" option - When enabled, there shouldn't be a prompt to save the login ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 14:58:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?