github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4689] [MERGED] [PM-17962] Exclude generated Hilt .java files from code coverage #5128

New Issue
Closed
opened 2025-11-26 23:54:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4689
Author: @vvolkgang
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @vvolkgang

Base: main ← Head: exclude-coverage

📝 Commits (1)

  • d220cdd Exclude generated Hilt .java files

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 app/build.gradle.kts (+1 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17962

📔 Objective

While troubleshooting https://github.com/bitwarden/android/pull/4681 noticed we're including generated .java Hilt files in our code coverage calculation. Confirmed the following change removes "HiltModules" classes from our report file here - https://github.com/bitwarden/android/actions/runs/13140684331

📸 Screenshots

Searching for "LazyKeyMap" in our report file before and after this PR fix:

Before After
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4689 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `exclude-coverage` --- ### 📝 Commits (1) - [`d220cdd`](https://github.com/bitwarden/android/commit/d220cdde0e9da9702850f5af4e486f6774e953a6) Exclude generated Hilt .java files ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-17962 ## 📔 Objective While troubleshooting https://github.com/bitwarden/android/pull/4681 noticed we're including generated .java Hilt files in our code coverage calculation. Confirmed the following change removes "HiltModules" classes from our report file here - https://github.com/bitwarden/android/actions/runs/13140684331 ## 📸 Screenshots Searching for "LazyKeyMap" in our report file before and after this PR fix: | Before | After | |--------|--------| | ![image](https://github.com/user-attachments/assets/e4656a8e-56ef-4eab-8647-e82aeea4dd83) | ![image](https://github.com/user-attachments/assets/ed3e0791-4247-4eab-a1c1-575be1abca90) | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5128
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?