github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4680] [MERGED] [PM-17694] Only update FIDO2 user verification status during single-tap sign-in #5123

New Issue
Closed
opened 2025-11-26 23:54:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4680
Author: @SaintPatrck
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-17694/fido2-auth-uv-fix

📝 Commits (1)

  • 33816c0 [PM-17694] Only update FIDO2 user verification status during single-tap sign-in

📊 Changes

4 files changed (+123 additions, -15 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+7 -6)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequest.kt (+13 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt (+1 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtilsTest.kt (+102 -7)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17694

📔 Objective

Update the FIDO2 authentication flow to ignore user verification results when single-tap sign-on is not used. This prevents redundant user verification from being performed if the user unlocked their vault to retrieve matching credentials.

📸 Screenshots

https://github.com/user-attachments/assets/eb1792c9-b1be-449c-a782-a31cc5f42c0f

https://github.com/user-attachments/assets/79ebafc9-2827-42c6-8bd4-c7a179fa4f6a

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4680 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-17694/fido2-auth-uv-fix` --- ### 📝 Commits (1) - [`33816c0`](https://github.com/bitwarden/android/commit/33816c040595897c3b44c704af6762bd35743da8) [PM-17694] Only update FIDO2 user verification status during single-tap sign-in ### 📊 Changes **4 files changed** (+123 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+7 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequest.kt` (+13 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt` (+1 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtilsTest.kt` (+102 -7) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-17694 ## 📔 Objective Update the FIDO2 authentication flow to ignore user verification results when single-tap sign-on is not used. This prevents redundant user verification from being performed if the user unlocked their vault to retrieve matching credentials. ## 📸 Screenshots https://github.com/user-attachments/assets/eb1792c9-b1be-449c-a782-a31cc5f42c0f https://github.com/user-attachments/assets/79ebafc9-2827-42c6-8bd4-c7a179fa4f6a ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?