github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4661] [MERGED] PM-17765 & PM-17767 Adjust spacing in vault screen and adjust account switcher icon size and minimum row height #5108

New Issue
Closed
opened 2025-11-26 23:54:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4661
Author: @dseverns-livefront
Created: 1/31/2025
Status: ✅ Merged
Merged: 1/31/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-17767-PM-17765-pixel-adjustments

📝 Commits (2)

  • b772901 PM-17765 vault screen eyebrow spacing
  • 4e1f27c PM-17767 Account switcher icon and row height size

📊 Changes

2 files changed (+19 additions, -8 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/account/BitwardenAccountSwitcher.kt (+4 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+15 -6)

📄 Description

🎟️ Tracking

PM-17765
PM-17767

📔 Objective

  • Fix the spacing in the vault screen between the start of the content and the items, move the 16.dp padding between items to the end of "each" section so for conditional content it will only be applied if needed.
  • Change icon size in account switcher drop down and set a minimum row height for each option per the desing.

📸 Screenshots

OLD | NEW
image

image

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4661 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-17767-PM-17765-pixel-adjustments` --- ### 📝 Commits (2) - [`b772901`](https://github.com/bitwarden/android/commit/b772901f356d24e6d4c2bc8612fdc097f568d6aa) PM-17765 vault screen eyebrow spacing - [`4e1f27c`](https://github.com/bitwarden/android/commit/4e1f27ca6eac185981e412c1f2244b822d85489a) PM-17767 Account switcher icon and row height size ### 📊 Changes **2 files changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/account/BitwardenAccountSwitcher.kt` (+4 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+15 -6) </details> ### 📄 Description ## 🎟️ Tracking [PM-17765](https://bitwarden.atlassian.net/browse/PM-17765) [PM-17767](https://bitwarden.atlassian.net/browse/PM-17767) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Fix the spacing in the vault screen between the start of the content and the items, move the 16.dp padding between items to the end of "each" section so for conditional content it will only be applied if needed. - Change icon size in account switcher drop down and set a minimum row height for each option per the desing. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots OLD | NEW ![image](https://github.com/user-attachments/assets/906fb77f-5e6b-4fc1-aa38-4aa55eac64b6) ![image](https://github.com/user-attachments/assets/33261458-b261-4189-9450-f9a24fcb7bb6) ![image](https://github.com/user-attachments/assets/538169da-8694-4d7d-9d56-6ed013246f87) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17765]: https://bitwarden.atlassian.net/browse/PM-17765?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17767]: https://bitwarden.atlassian.net/browse/PM-17767?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?