github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 90 Wiki Activity

[PR #4652] [MERGED] PM-17376, PM-17380, PM-17385: Update card padding and layout #5101

New Issue
Closed
opened 2025-11-26 23:54:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4652
Author: @david-livefront
Created: 1/30/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @david-livefront

Base: main ← Head: PM-17376-PM-17380-PM-17385-card-padding

📝 Commits (1)

  • b313772 PM-17376, PM-17380, PM-17385: Update card padding and layout

📊 Changes

43 files changed (+606 additions, -856 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt (+35 -37)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginScreen.kt (+7 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+14 -28)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt (+39 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenDateSelectButton.kt (+13 -6)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimeSelectButton.kt (+13 -6)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt (+76 -68)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/EnvironmentSelector.kt (+44 -21)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenHiddenPasswordField.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt (+85 -41)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordFieldWithActions.kt (+0 -199)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt (+63 -36)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextFieldWithActions.kt (+0 -160)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/listitem/BitwardenGroupItem.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/listitem/BitwardenListItem.kt (+4 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/row/BitwardenExternalLinkRow.kt (+3 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/row/BitwardenRowOfActions.kt (+1 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/row/BitwardenTextRow.kt (+2 -2)

...and 23 more files

📄 Description

🎟️ Tracking

PM-17376
PM-17380
PM-17385

📔 Objective

This PR makes updates to the inner padding and layouts of card based composables in order to be align inner content.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4652 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-17376-PM-17380-PM-17385-card-padding` --- ### 📝 Commits (1) - [`b313772`](https://github.com/bitwarden/android/commit/b3137726384cbf75d30ff23795cb70aaaadf5844) PM-17376, PM-17380, PM-17385: Update card padding and layout ### 📊 Changes **43 files changed** (+606 additions, -856 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt` (+35 -37) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginScreen.kt` (+7 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+14 -28) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt` (+39 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenDateSelectButton.kt` (+13 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimeSelectButton.kt` (+13 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt` (+76 -68) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/EnvironmentSelector.kt` (+44 -21) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenHiddenPasswordField.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt` (+85 -41) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordFieldWithActions.kt` (+0 -199) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt` (+63 -36) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextFieldWithActions.kt` (+0 -160) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/listitem/BitwardenGroupItem.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/listitem/BitwardenListItem.kt` (+4 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/row/BitwardenExternalLinkRow.kt` (+3 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/row/BitwardenRowOfActions.kt` (+1 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/row/BitwardenTextRow.kt` (+2 -2) _...and 23 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-17376](https://bitwarden.atlassian.net/browse/PM-17376) [PM-17380](https://bitwarden.atlassian.net/browse/PM-17380) [PM-17385](https://bitwarden.atlassian.net/browse/PM-17385) ## 📔 Objective This PR makes updates to the inner padding and layouts of card based composables in order to be align inner content. ## 📸 Screenshots | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/cf5ec81e-9375-4bb0-8e7d-37dc988eaf52" width="300" /> | <img src="https://github.com/user-attachments/assets/855be9d2-81bc-4d04-8f30-704997846d17" width="300" /> | | <img src="https://github.com/user-attachments/assets/ae3e535a-8592-4623-b758-0da1a3069c9e" width="300" /> | <img src="https://github.com/user-attachments/assets/7e42b281-71fb-430e-af82-ea2d5da07f4b" width="300" /> | | <img src="https://github.com/user-attachments/assets/695e5040-5b05-4a51-9c23-013e2d6deeea" width="300" /> | <img src="https://github.com/user-attachments/assets/01e1f9f4-5553-4453-8d09-8563fb2e7466" width="300" /> | | <img src="https://github.com/user-attachments/assets/f608f679-2ba6-4590-b399-9eb82d39b65e" width="300" /> | <img src="https://github.com/user-attachments/assets/adb1326a-239d-4da3-8347-d6015aebf900" width="300" /> | | <img src="https://github.com/user-attachments/assets/eecab78d-bb27-4edb-8452-f0ea909518bb" width="300" /> | <img src="https://github.com/user-attachments/assets/8c115231-b365-4090-a03a-9a4e78d207aa" width="300" /> | | <img src="https://github.com/user-attachments/assets/b60b695a-d97d-466c-8f4b-374f1f4196dc" width="300" /> | <img src="https://github.com/user-attachments/assets/8ad3a2d7-2fee-490c-97c3-34793e47feb6" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17376]: https://bitwarden.atlassian.net/browse/PM-17376?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17380]: https://bitwarden.atlassian.net/browse/PM-17380?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17385]: https://bitwarden.atlassian.net/browse/PM-17385?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?