github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4645] [MERGED] PM-17388 Update existing and v3 email verification screen to match design audit #5098

New Issue
Closed
opened 2025-11-26 23:53:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4645
Author: @dseverns-livefront
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-17388-email-verification-update

📝 Commits (5)

  • cb865cd PM-17388 replace copy on 1.5 version UI with the CTA action to change email, minor UI updates on v3 design to use outlined button
  • 9e4bb28 remove broken test
  • d6a8bb4 pr feedbeezy
  • 0abef70 skrrrrt
  • 4eed875 asleep at the wheel

📊 Changes

8 files changed (+33 additions, -110 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+0 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailNavigation.kt (+0 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt (+32 -43)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailViewModel.kt (+0 -16)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt (+0 -2)
📝 app/src/main/res/values/strings.xml (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreenTest.kt (+0 -31)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailViewModelTest.kt (+0 -12)

📄 Description

🎟️ Tracking

PM-17388

📔 Objective

  • In the existing version of the email screen replace the bottom copy/links with the CTA button matching v3 design.
  • In v3 version update from text button to outlined button per design.

📸 Screenshot

https://github.com/user-attachments/assets/0a2e2369-5a62-4fd8-89d0-8d0d231f809c

s

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4645 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-17388-email-verification-update` --- ### 📝 Commits (5) - [`cb865cd`](https://github.com/bitwarden/android/commit/cb865cd4cec81f52a3e59f8268ce6990f03c4110) PM-17388 replace copy on 1.5 version UI with the CTA action to change email, minor UI updates on v3 design to use outlined button - [`9e4bb28`](https://github.com/bitwarden/android/commit/9e4bb28148be267f9330cc957abbbd48a7ae86a5) remove broken test - [`d6a8bb4`](https://github.com/bitwarden/android/commit/d6a8bb48405c209e1a96cd4d1a9a83ae8d7dfbac) pr feedbeezy - [`0abef70`](https://github.com/bitwarden/android/commit/0abef7049a38dd16a2ec7d843db9d9ca27d04076) skrrrrt - [`4eed875`](https://github.com/bitwarden/android/commit/4eed875987941d2398667139008f3f19c7dcc901) asleep at the wheel ### 📊 Changes **8 files changed** (+33 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+0 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailNavigation.kt` (+0 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt` (+32 -43) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailViewModel.kt` (+0 -16) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt` (+0 -2) 📝 `app/src/main/res/values/strings.xml` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreenTest.kt` (+0 -31) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailViewModelTest.kt` (+0 -12) </details> ### 📄 Description ## 🎟️ Tracking [PM-17388](https://bitwarden.atlassian.net/browse/PM-17388) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - In the existing version of the email screen replace the bottom copy/links with the CTA button matching v3 design. - In v3 version update from text button to outlined button per design. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshot https://github.com/user-attachments/assets/0a2e2369-5a62-4fd8-89d0-8d0d231f809c s <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17388]: https://bitwarden.atlassian.net/browse/PM-17388?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?