github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4640] [MERGED] PM-16625 PM-16626 PM-16627 Coach marks 4-6 on generator screen #5093

New Issue
Closed
opened 2025-11-26 23:53:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4640
Author: @dseverns-livefront
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-16625-PM-16626-PM-16627-generator-coachmarks-4-6

📝 Commits (6)

  • f3a1abe PM-16625 PM-16626 PM-16627 adds coachmark 4-6 to the generator tour, refactor screen to use LazyColumn so able to seach for search marks if they are off screen.
  • e2c6f99 whoops
  • e71c64d Pr feedback
  • b56f1d5 Update tool tip layout to match design
  • b80039e comment
  • 4a1ca40 add names

📊 Changes

8 files changed (+613 additions, -425 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScopeInstance.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/LazyListCoachMarkState.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/BitwardenToolTip.kt (+33 -17)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/BitwardenToolTipStateImpl.kt (+4 -0)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/color/BitwardenToolTipColors.kt (+0 -25)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+507 -379)
📝 app/src/main/res/values/strings.xml (+5 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt (+56 -0)

📄 Description

🎟️ Tracking

📔 Objective

  • show the remaining three coach marks and complete the tour on the last one.

📸 Screenshots

https://github.com/user-attachments/assets/1cce2e3b-d434-4dcd-83a6-ccacfa9f3435

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4640 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-16625-PM-16626-PM-16627-generator-coachmarks-4-6` --- ### 📝 Commits (6) - [`f3a1abe`](https://github.com/bitwarden/android/commit/f3a1abe1f1a9d9fbc872fe47c9fb59d096a187ef) PM-16625 PM-16626 PM-16627 adds coachmark 4-6 to the generator tour, refactor screen to use LazyColumn so able to seach for search marks if they are off screen. - [`e2c6f99`](https://github.com/bitwarden/android/commit/e2c6f99ba975191da2fe49a0803621f6e4a47222) whoops - [`e71c64d`](https://github.com/bitwarden/android/commit/e71c64d5897645339570b38be65040129c47861e) Pr feedback - [`b56f1d5`](https://github.com/bitwarden/android/commit/b56f1d58f11b5c71781e6b77ce93a74a48c7a47f) Update tool tip layout to match design - [`b80039e`](https://github.com/bitwarden/android/commit/b80039e177d58ba94b399aafbc9af250cec063ee) comment - [`4a1ca40`](https://github.com/bitwarden/android/commit/4a1ca4052c8e22867a751c5e8a9fb3415cc86e84) add names ### 📊 Changes **8 files changed** (+613 additions, -425 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScopeInstance.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/LazyListCoachMarkState.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/BitwardenToolTip.kt` (+33 -17) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/BitwardenToolTipStateImpl.kt` (+4 -0) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/tooltip/color/BitwardenToolTipColors.kt` (+0 -25) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+507 -379) 📝 `app/src/main/res/values/strings.xml` (+5 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt` (+56 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - show the remaining three coach marks and complete the tour on the last one. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/1cce2e3b-d434-4dcd-83a6-ccacfa9f3435 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5093
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?