github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #818] [MERGED] Tweaks to accessibility autofill overlay #50812

New Issue
Closed
opened 2026-05-01 14:12:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 14:12:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/818
Author: @mpbw2
Created: 4/2/2020
Status: ✅ Merged
Merged: 4/2/2020
Merged by: @mpbw2

Base: master ← Head: tweaks-a11y

📝 Commits (1)

  • 42f523a Tweaks to accessibility autofill overlay

📊 Changes

1 file changed (+17 additions, -24 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+17 -24)

📄 Description

We're no longer parsing for total app vs non-app window dimensions as it apparently can't be trusted across ROMs (Repro'd a condition on a non-Pixel phone where a 4th "mystery" system window would appear and disappear (logically, not visibly) at regular intervals while sitting on a login page, throwing off the measurements and causing the overlay to fly off-screen (i.e. disappear shortly after appearing)

We're now explicitly checking for a single InputMethod window for measuring software keyboards, and ignoring the rest. This seems to have stabilized the overlay behavior, though it really needs more testing (Need more examples of websites with issues, not just browsers)

Also made improvements to measurements used when automatically flipping from bottom to top-aligned overlay, which helps a bit when we're up against the password row view that appears on the top of the keyboard but is not reported as part of the inputMethod window dimensions (still not perfect, but better)

┆Issue is synchronized with this Asana task by Unito

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/818 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/2/2020 **Status:** ✅ Merged **Merged:** 4/2/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `tweaks-a11y` --- ### 📝 Commits (1) - [`42f523a`](https://github.com/bitwarden/android/commit/42f523ad885d12d15e151144c83e03b5bed179c2) Tweaks to accessibility autofill overlay ### 📊 Changes **1 file changed** (+17 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+17 -24) </details> ### 📄 Description We're no longer parsing for total app vs non-app window dimensions as it apparently can't be trusted across ROMs (Repro'd a condition on a non-Pixel phone where a 4th "mystery" system window would appear and disappear (logically, not visibly) at regular intervals while sitting on a login page, throwing off the measurements and causing the overlay to fly off-screen (i.e. disappear shortly after appearing) We're now explicitly checking for a single InputMethod window for measuring software keyboards, and ignoring the rest. This seems to have stabilized the overlay behavior, though it really needs more testing (Need more examples of websites with issues, not just browsers) Also made improvements to measurements used when automatically flipping from bottom to top-aligned overlay, which helps a bit when we're up against the password row view that appears on the top of the keyboard but is not reported as part of the inputMethod window dimensions (still not perfect, but better) ┆Issue is synchronized with this [Asana task](https://app.asana.com/0/1169444489336079/1169697772146542) by [Unito](https://www.unito.io/learn-more) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 14:12:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#50812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?