github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4613] [MERGED] PM-16622 PM-16623 and PM-16624 Add the first three coach marks to the generator tour #5074

New Issue
Closed
opened 2025-11-26 23:53:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4613
Author: @dseverns-livefront
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-16622-generator-coachmarks

📝 Commits (3)

  • 7c8eff1 PM-16622 PM-16623 and PM-16624 adding the first three coachmarks to the segemented controls along with how the nav bar scrim shows
  • 1668065 nix suppression
  • f7318b4 remove un needed int state

📊 Changes

16 files changed (+413 additions, -113 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkContainer.kt (+6 -7)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkState.kt (+8 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/model/CoachMarkHighlightShape.kt (+11 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/segment/BitwardenSegmentedButton.kt (+37 -18)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorGraphNavigation.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorNavigation.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+196 -55)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+6 -1)
➕ app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/model/ExploreGeneratorCoachMark.kt (+13 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+1 -1)
📝 app/src/main/res/values/strings.xml (+9 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt (+94 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+6 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+13 -13)

📄 Description

🎟️ Tracking

PM-16622
PM-16623
PM-16624

📔 Objective

  • Show the first three coach marks on the segmented controls on the generator screen.
  • NOTE: I did resolve with Emily that it's fine if the "highlight" effect for these is a per option implementation.

📸 Screenshots

https://github.com/user-attachments/assets/0e309bbb-e4b9-47de-b9d2-a2879576d8b5

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4613 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-16622-generator-coachmarks` --- ### 📝 Commits (3) - [`7c8eff1`](https://github.com/bitwarden/android/commit/7c8eff1256ed3102bce7998e521b034990d7b4e1) PM-16622 PM-16623 and PM-16624 adding the first three coachmarks to the segemented controls along with how the nav bar scrim shows - [`1668065`](https://github.com/bitwarden/android/commit/1668065dd332b17e15342995893e21329726ce6c) nix suppression - [`f7318b4`](https://github.com/bitwarden/android/commit/f7318b405e9b348a66c0a3de934fd9524987fc0a) remove un needed int state ### 📊 Changes **16 files changed** (+413 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkContainer.kt` (+6 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkState.kt` (+8 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/coachmark/model/CoachMarkHighlightShape.kt` (+11 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/segment/BitwardenSegmentedButton.kt` (+37 -18) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorGraphNavigation.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorNavigation.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+196 -55) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+6 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/model/ExploreGeneratorCoachMark.kt` (+13 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+1 -1) 📝 `app/src/main/res/values/strings.xml` (+9 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt` (+94 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+6 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+13 -13) </details> ### 📄 Description ## 🎟️ Tracking [PM-16622](https://bitwarden.atlassian.net/browse/PM-16622) [PM-16623](https://bitwarden.atlassian.net/browse/PM-16623) [PM-16624](https://bitwarden.atlassian.net/browse/PM-16624) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Show the first three coach marks on the segmented controls on the generator screen. - NOTE: I did resolve with Emily that it's fine if the "highlight" effect for these is a per option implementation. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/0e309bbb-e4b9-47de-b9d2-a2879576d8b5 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-16622]: https://bitwarden.atlassian.net/browse/PM-16622?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-16623]: https://bitwarden.atlassian.net/browse/PM-16623?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-16624]: https://bitwarden.atlassian.net/browse/PM-16624?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5074
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?