github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4611] [MERGED] [PM-17374] [PM-17375] [PM-17379] - LandingScreen Design Audit #5072

New Issue
Closed
opened 2025-11-26 23:53:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4611
Author: @phil-livefront
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-17374-PM-17375-Landing-screen-design-audit

📝 Commits (7)

  • 65f4967 PM-17374 PM-17375 - LandingScreen design audit - fix image size and update login text
  • 57f9700 PM-17379 - update create account button text and styling on landing screen
  • 8a3738c fix linter issue
  • b69916e fix padding values
  • 906883d padding fixes and replacing colorFilter that was removed incorrectly
  • ffc202e fix tests and cleanup spacer logic
  • 2ddc1d6 Merge branch 'main' into phil/PM-17374-PM-17375-Landing-screen-design-audit

📊 Changes

6 files changed (+69 additions, -68 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+15 -21)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+6 -0)
➕ app/src/main/res/drawable/bitwarden_logo.xml (+44 -0)
➖ app/src/main/res/drawable/logo.xml (+0 -44)
📝 app/src/main/res/values/strings.xml (+3 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-17374
PM-17375
PM-17379

📔 Objective

  • Fix the Bitwarden logo size and update the login text verbiage. The original image was including the entire background so I imported just the logo itself with no extra padding on the sides.
  • Update the overall layout to match Figma designs
  • Update create account button text and styling on landing screen

📸 Screenshots

Pixel 9

Without top bar

Screenshot_1737742244

With top bar

Screenshot_1737742331

Landscape without top bar

Screenshot_1737742274

Landscape with top bar

Screenshot_1737744569

Small Phone

Without top bar

Screenshot_1737744623

With top bar

Screenshot_1737744705

Landscape without top bar

Screenshot_1737744656

Landscape with top bar

Screenshot_1737744757

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4611 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-17374-PM-17375-Landing-screen-design-audit` --- ### 📝 Commits (7) - [`65f4967`](https://github.com/bitwarden/android/commit/65f4967196d1c9d2aeee26a02968b745f120a7f0) PM-17374 PM-17375 - LandingScreen design audit - fix image size and update login text - [`57f9700`](https://github.com/bitwarden/android/commit/57f9700e6adb43f322895422fb02e732c67ecc11) PM-17379 - update create account button text and styling on landing screen - [`8a3738c`](https://github.com/bitwarden/android/commit/8a3738cd9ecbe74a69e0014fd234e6cc74bdf7f0) fix linter issue - [`b69916e`](https://github.com/bitwarden/android/commit/b69916e62a74ea7e0db3f172f57da486846dbaa4) fix padding values - [`906883d`](https://github.com/bitwarden/android/commit/906883d34cefaf30a7cf3f99bc1bc4bf41648d4a) padding fixes and replacing colorFilter that was removed incorrectly - [`ffc202e`](https://github.com/bitwarden/android/commit/ffc202e32294f1c2e7b7d9f9cb204f19945a86a6) fix tests and cleanup spacer logic - [`2ddc1d6`](https://github.com/bitwarden/android/commit/2ddc1d67a3a5ffae8f768b32a49f2cfa646cabbe) Merge branch 'main' into phil/PM-17374-PM-17375-Landing-screen-design-audit ### 📊 Changes **6 files changed** (+69 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+15 -21) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+6 -0) ➕ `app/src/main/res/drawable/bitwarden_logo.xml` (+44 -0) ➖ `app/src/main/res/drawable/logo.xml` (+0 -44) 📝 `app/src/main/res/values/strings.xml` (+3 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-17374](https://bitwarden.atlassian.net/browse/PM-17374) [PM-17375](https://bitwarden.atlassian.net/browse/PM-17375) [PM-17379](https://bitwarden.atlassian.net/browse/PM-17379) ## 📔 Objective - Fix the Bitwarden logo size and update the login text verbiage. The original image was including the entire background so I imported just the logo itself with no extra padding on the sides. - Update the overall layout to match Figma designs - Update create account button text and styling on landing screen ## 📸 Screenshots ## Pixel 9 ### Without top bar ![Screenshot_1737742244](https://github.com/user-attachments/assets/c56c301b-4af9-4934-8aa6-3b1957cf9c51) ### With top bar ![Screenshot_1737742331](https://github.com/user-attachments/assets/5c9bef7e-ea50-4ff7-8400-8549e59ab363) ### Landscape without top bar ![Screenshot_1737742274](https://github.com/user-attachments/assets/67d7f3dc-5a6f-486f-a5b7-e82ce9847527) ### Landscape with top bar ![Screenshot_1737744569](https://github.com/user-attachments/assets/c426b36e-347b-42bf-8123-6988883700a8) ## Small Phone ### Without top bar ![Screenshot_1737744623](https://github.com/user-attachments/assets/454ac963-ede9-4593-858d-cf60a0362596) ### With top bar ![Screenshot_1737744705](https://github.com/user-attachments/assets/94266622-3f5a-430e-8e70-70e31a21b8b9) ### Landscape without top bar ![Screenshot_1737744656](https://github.com/user-attachments/assets/b083ba2f-2342-47b2-afd7-20699a3c223b) ### Landscape with top bar ![Screenshot_1737744757](https://github.com/user-attachments/assets/cc3fcf53-ef39-40d9-925d-f78b89142caf) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17374]: https://bitwarden.atlassian.net/browse/PM-17374?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17375]: https://bitwarden.atlassian.net/browse/PM-17375?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17379]: https://bitwarden.atlassian.net/browse/PM-17379?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5072
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?