[PR #4569] [MERGED] [QA-980] Adding missing testTags for Custom fields #5045

New Issue

GiteaMirror · 2025-11-26T23:53:16-06:00

GiteaMirror commented

2025-11-26 23:53:16 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4569
Author: @ifernandezdiaz
Created: 1/15/2025
Status: ✅ Merged
Merged: 1/21/2025
Merged by: @ifernandezdiaz

Base: main ← Head: QA-980/adding-testTags-to-custom-fields

📝 Commits (3)

2203225 Adding missing testTag for Custom fields
14ac731 Updating branch + fixing merge conflicts
58069e2 Adding David suggestion

📊 Changes

2 files changed (+24 additions, -9 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomField.kt (+13 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCustomField.kt (+11 -4)

📄 Description

🎟️ Tracking

📔 Objective

This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4569 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 1/15/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `main` ← **Head:** `QA-980/adding-testTags-to-custom-fields` --- ### 📝 Commits (3) - [`2203225`](https://github.com/bitwarden/android/commit/220322547565efe70bee10e8206380e4389f287d) Adding missing testTag for Custom fields - [`14ac731`](https://github.com/bitwarden/android/commit/14ac731281ff3756ef2d99a0131a8ece22b8a21c) Updating branch + fixing merge conflicts - [`58069e2`](https://github.com/bitwarden/android/commit/58069e21e9bd4409d914015b0c8bbf853640be58) Adding David suggestion ### 📊 Changes **2 files changed** (+24 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomField.kt` (+13 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCustomField.kt` (+11 -4) </details> ### 📄 Description ## 🎟️ Tracking  ## 📔 Objective This work is a subtask of [QA-947](https://bitwarden.atlassian.net/browse/QA-947), a story created to group all the native app views that contain elements without Automation IDs. NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests ## 📸 Screenshots  ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [QA-947]: https://bitwarden.atlassian.net/browse/QA-947?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:53:17 -06:00

GiteaMirror closed this issue