github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4525] [MERGED] [PM-16670] Force app to sync after 2FA notice #5013

New Issue
Closed
opened 2025-11-26 23:52:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4525
Author: @andrebispo5
Created: 1/7/2025
Status: ✅ Merged
Merged: 1/8/2025
Merged by: @andrebispo5

Base: release/2024.12-rc13 ← Head: pm-16670/sync-2fa-notice

📝 Commits (5)

  • 46c1995 [PM-16670] Force vault to sync by remove last sync date
  • 263fb9d [PM-16670] Make sure the app syncs before launching the notice to the user
  • 609ca50 [PM-16670] Fix tests
  • bd30ce6 [PM-16670] Update tests
  • ab1f01c Merge branch 'release/2024.12-rc13' into pm-16670/sync-2fa-notice

📊 Changes

4 files changed (+64 additions, -1 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModel.kt (+6 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+47 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModelTest.kt (+10 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16670

📔 Objective

We need the app to sync when the user leaves the app to setup a two factor method and comes back. This will void the grace period of 30 mins between vault syncs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4525 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 1/7/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `release/2024.12-rc13` ← **Head:** `pm-16670/sync-2fa-notice` --- ### 📝 Commits (5) - [`46c1995`](https://github.com/bitwarden/android/commit/46c199507e24e11a890e84a78a68556e92f4d0dd) [PM-16670] Force vault to sync by remove last sync date - [`263fb9d`](https://github.com/bitwarden/android/commit/263fb9dd96c7887820729f7339f61af57de87a7e) [PM-16670] Make sure the app syncs before launching the notice to the user - [`609ca50`](https://github.com/bitwarden/android/commit/609ca508c2c34bcb42a77608c40e9b3d40e20e2e) [PM-16670] Fix tests - [`bd30ce6`](https://github.com/bitwarden/android/commit/bd30ce6b4dc38978a0c27f588170f6c7f20a9ac4) [PM-16670] Update tests - [`ab1f01c`](https://github.com/bitwarden/android/commit/ab1f01c01fa9f0c9a647fa7eb39877c3c6ec60a3) Merge branch 'release/2024.12-rc13' into pm-16670/sync-2fa-notice ### 📊 Changes **4 files changed** (+64 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModel.kt` (+6 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+47 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModelTest.kt` (+10 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-16670 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> We need the app to sync when the user leaves the app to setup a two factor method and comes back. This will void the grace period of 30 mins between vault syncs. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5013
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?