github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4521] [MERGED] [PM-8217] Add local feature flag to ignore environment validation #5010

New Issue
Closed
opened 2025-11-26 23:52:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4521
Author: @andrebispo5
Created: 1/6/2025
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @andrebispo5

Base: main ← Head: pm-8217/local-flag-ignore-env-validation

📝 Commits (4)

  • 00437a4 [PM-8217] Add local feature flag to bypass environment validation.
  • ccbd1ef [PM-8217] Consume flag to ignore environment check. Add tests.
  • e9f7ad2 [PM-8217] Add tests to feature flag IgnoreEnvironmentCheck
  • d8c8e33 [PM-8217] Fix failing test

📊 Changes

7 files changed (+68 additions, -71 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+3 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+2 -0)
📝 app/src/main/res/values/strings_non_localized.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+40 -70)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+10 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+2 -0)

📄 Description

Backport: https://github.com/bitwarden/android/pull/4516

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8217

📔 Objective

In order for QA to fully test the new device two factor notice feature, we need to bypass the requirement of only showing the notice to Bitwarden Cloud environments.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4521 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/6/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-8217/local-flag-ignore-env-validation` --- ### 📝 Commits (4) - [`00437a4`](https://github.com/bitwarden/android/commit/00437a48b860302f429b54acdf289a7a32fe2656) [PM-8217] Add local feature flag to bypass environment validation. - [`ccbd1ef`](https://github.com/bitwarden/android/commit/ccbd1efca525df858f371b946e11a9aa20624e2b) [PM-8217] Consume flag to ignore environment check. Add tests. - [`e9f7ad2`](https://github.com/bitwarden/android/commit/e9f7ad245c2330afeb26e8e98a4bd60cf6fb59a8) [PM-8217] Add tests to feature flag IgnoreEnvironmentCheck - [`d8c8e33`](https://github.com/bitwarden/android/commit/d8c8e33f8176315c507dd5f73c14d4b732ea7883) [PM-8217] Fix failing test ### 📊 Changes **7 files changed** (+68 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+3 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+2 -0) 📝 `app/src/main/res/values/strings_non_localized.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+40 -70) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+10 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+2 -0) </details> ### 📄 Description `Backport:` https://github.com/bitwarden/android/pull/4516 ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-8217 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> In order for QA to fully test the new device two factor notice feature, we need to bypass the requirement of only showing the notice to Bitwarden Cloud environments. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5010
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?