github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4512] [MERGED] [PM-15969] Users with Can Edit access cannot assign collections #5006

New Issue
Closed
opened 2025-11-26 23:52:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4512
Author: @andrebispo5
Created: 1/1/2025
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @andrebispo5

Base: release/2024.12-rc13 ← Head: pm-15969/can-edit-assign-to-collection

📝 Commits (4)

  • 6160402 [PM-15969] Fix bug where Edit permission couldn't assign item to collections
  • 7746b6c [PM-15969] Update tests to reflect previous changes
  • 5f40ac3 [PM-15969] Update test to match logic changes
  • d192065 [PM-15969] Update inline comment

📊 Changes

3 files changed (+14 additions, -29 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensions.kt (+6 -19)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+7 -7)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensionsTest.kt (+1 -3)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15969

📔 Objective

Fix bug where users with Can Edit permission in one collection could not use "assign to collection".

📸 Screenshots

https://github.com/user-attachments/assets/9c9b98de-f5f3-4fdc-a294-f16d27de27ec

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4512 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 1/1/2025 **Status:** ✅ Merged **Merged:** 1/6/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `release/2024.12-rc13` ← **Head:** `pm-15969/can-edit-assign-to-collection` --- ### 📝 Commits (4) - [`6160402`](https://github.com/bitwarden/android/commit/616040218678625499640f2a6d0894b69ae47fc3) [PM-15969] Fix bug where Edit permission couldn't assign item to collections - [`7746b6c`](https://github.com/bitwarden/android/commit/7746b6c0c72c82c959a1c1c36811927dc1043027) [PM-15969] Update tests to reflect previous changes - [`5f40ac3`](https://github.com/bitwarden/android/commit/5f40ac3004e06c6f3169fd6730c41a37efb6f6b9) [PM-15969] Update test to match logic changes - [`d192065`](https://github.com/bitwarden/android/commit/d19206505426b5e66624cd2367d229bd95a6d92b) [PM-15969] Update inline comment ### 📊 Changes **3 files changed** (+14 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensions.kt` (+6 -19) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+7 -7) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensionsTest.kt` (+1 -3) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-15969 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Fix bug where users with Can Edit permission in one collection could not use "assign to collection". ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> https://github.com/user-attachments/assets/9c9b98de-f5f3-4fdc-a294-f16d27de27ec ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5006
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?