github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4472] [MERGED] PM-16053 - Text in Prompt to Restart App After Changing Language in Settings #4976

New Issue
Closed
opened 2025-11-26 23:52:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4472
Author: @phil-livefront
Created: 12/13/2024
Status: ✅ Merged
Merged: 12/13/2024
Merged by: @phil-livefront

Base: main ← Head: phil/PM-16053-Text-in-Prompt-to-Restart-App-After-Changing-Language-in-Settings

📝 Commits (2)

  • 38aae95 PM-16053 - Updated the dialog to use the string version of the Text vs the Text itself
  • 4246412 Merge branch 'main' into phil/PM-16053-Text-in-Prompt-to-Restart-App-After-Changing-Language-in-Settings

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-16053

📔 Objective

  • Previously, the dialog used the Text value directly within the string resource. This update leverages the invoke function to correctly resolve and display the actual string of the language correctly.

📸 Screenshots

Before

https://github.com/user-attachments/assets/a9b4a601-ca1a-4ebc-900a-919d1addf4ed

After

https://github.com/user-attachments/assets/a2f30bd6-cc9b-47ad-ade5-d77f94e3975f

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4472 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-16053-Text-in-Prompt-to-Restart-App-After-Changing-Language-in-Settings` --- ### 📝 Commits (2) - [`38aae95`](https://github.com/bitwarden/android/commit/38aae95e2e58606809d7db9f9d3846157553615c) PM-16053 - Updated the dialog to use the string version of the Text vs the Text itself - [`4246412`](https://github.com/bitwarden/android/commit/42464123cc62b60bed79ce2acb631289610d847e) Merge branch 'main' into phil/PM-16053-Text-in-Prompt-to-Restart-App-After-Changing-Language-in-Settings ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-16053](https://bitwarden.atlassian.net/browse/PM-16053) ## 📔 Objective - Previously, the dialog used the Text value directly within the string resource. This update leverages the `invoke` function to correctly resolve and display the actual string of the language correctly. ## 📸 Screenshots ## Before https://github.com/user-attachments/assets/a9b4a601-ca1a-4ebc-900a-919d1addf4ed ## After https://github.com/user-attachments/assets/a2f30bd6-cc9b-47ad-ade5-d77f94e3975f ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-16053]: https://bitwarden.atlassian.net/browse/PM-16053?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4976
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?