github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4460] [MERGED] PM-15976 - App crashes when non-english language user tries to create account #4965

New Issue
Closed
opened 2025-11-26 23:52:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4460
Author: @phil-livefront
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/13/2024
Merged by: @phil-livefront

Base: main ← Head: phil/PM-15976-app-crashes-when-non-english-languages-tries-to-create-account

📝 Commits (2)

  • d21a125 PM-15976 - Added logic to make sure the start index isn't -1 when trying to highlight
  • 086b05a PR comments

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/Text.kt (+6 -0)

📄 Description

🎟️ Tracking

PM-15976

📔 Objective

  • This PR addresses a crash caused by an IndexOutOfBoundsException in the createClickableAnnotatedString function. The crash occurred when attempting to create links for text highlights that were not present in the main string, which could happen in scenarios where translations were incomplete or mismatched.

We did have translations for strTerms and strPrivacy but not for strTermsAndPrivacy which was breaking out logic since startIndex came back as -1 which caused the java.lang.IndexOutOfBoundsException: setSpan (-1 ... 0) starts before 0

val strTerms = stringResource(id = R.string.terms_of_service)
val strPrivacy = stringResource(id = R.string.privacy_policy)
val strTermsAndPrivacy = stringResource(
    id = R.string.by_continuing_you_agree_to_the_terms_of_service_and_privacy_policy,
)

📸 Screenshots

https://github.com/user-attachments/assets/b0c185bb-5a82-4c1a-8e47-d1fdf8ccb4de

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4460 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-15976-app-crashes-when-non-english-languages-tries-to-create-account` --- ### 📝 Commits (2) - [`d21a125`](https://github.com/bitwarden/android/commit/d21a1255dc563a05fe9b66663c70f07fe550b0a3) PM-15976 - Added logic to make sure the start index isn't -1 when trying to highlight - [`086b05a`](https://github.com/bitwarden/android/commit/086b05a75a37e49425532c390a5011fee41c7bee) PR comments ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/Text.kt` (+6 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-15976](https://bitwarden.atlassian.net/browse/PM-15976) ## 📔 Objective - This PR addresses a crash caused by an IndexOutOfBoundsException in the `createClickableAnnotatedString` function. The crash occurred when attempting to create links for text highlights that were not present in the main string, which could happen in scenarios where translations were incomplete or mismatched. We did have translations for `strTerms` and `strPrivacy` but not for `strTermsAndPrivacy` which was breaking out logic since `startIndex` came back as `-1` which caused the `java.lang.IndexOutOfBoundsException: setSpan (-1 ... 0) starts before 0` ``` val strTerms = stringResource(id = R.string.terms_of_service) val strPrivacy = stringResource(id = R.string.privacy_policy) val strTermsAndPrivacy = stringResource( id = R.string.by_continuing_you_agree_to_the_terms_of_service_and_privacy_policy, ) ``` ## 📸 Screenshots https://github.com/user-attachments/assets/b0c185bb-5a82-4c1a-8e47-d1fdf8ccb4de ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-15976]: https://bitwarden.atlassian.net/browse/PM-15976?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4965
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?