github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4458] [MERGED] [PM-15176] chore(ci): Fix fastlane build artifacts names and filepaths #4964

New Issue
Closed
opened 2025-11-26 23:52:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4458
Author: @vvolkgang
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/13/2024
Merged by: @vvolkgang

Base: main ← Head: fix-fastlane

📝 Commits (5)

  • 72db4d9 fix fastlane file names
  • 8a29f0c fix prod aab path
  • 0ddd994 Fix standardRelease folder paths
  • 23649fb Revert "Fix standardRelease folder paths"
  • 63ef7ac Merge branch 'main' into fix-fastlane

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 fastlane/Fastfile (+5 -5)

📄 Description

🎟️ Tracking

PM-15176

📔 Objective

Following https://github.com/bitwarden/android/pull/4446, fastlane file needs to be updated to match the new apk names. https://github.com/bitwarden/android/pull/4467 will fix AABs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4458 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `fix-fastlane` --- ### 📝 Commits (5) - [`72db4d9`](https://github.com/bitwarden/android/commit/72db4d9502f5dea8616a4745bec0014a9e8bbc29) fix fastlane file names - [`8a29f0c`](https://github.com/bitwarden/android/commit/8a29f0cce6ad5102583af5342f68deeb7529e2dc) fix prod aab path - [`0ddd994`](https://github.com/bitwarden/android/commit/0ddd994fd01a4584f5137c65b9e18004d9a646b4) Fix standardRelease folder paths - [`23649fb`](https://github.com/bitwarden/android/commit/23649fbce050f6b3cbe2ea46d9e1d049c7fce0f7) Revert "Fix standardRelease folder paths" - [`63ef7ac`](https://github.com/bitwarden/android/commit/63ef7ac577fc301540685dfb876677cb567aa8bb) Merge branch 'main' into fix-fastlane ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `fastlane/Fastfile` (+5 -5) </details> ### 📄 Description ## 🎟️ Tracking PM-15176 ## 📔 Objective Following https://github.com/bitwarden/android/pull/4446, fastlane file needs to be updated to match the new apk names. https://github.com/bitwarden/android/pull/4467 will fix AABs. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4964
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?