github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4455] [MERGED] PM-15383 PM-15381 - Show the google play review prompt #4961

New Issue
Closed
opened 2025-11-26 23:52:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:52:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4455
Author: @dseverns-livefront
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-15831-PM-15838-show-review-prompt

📝 Commits (6)

  • 0c03b26 PM-15383 and PM-15381 show the google play review prompt (if possible) and delay on vault screen
  • 217b8aa fmt
  • 6757fee always show the toast in debug mode when prompted
  • d5079b7 pr feedback: update readme and remove google binary from fdroid build
  • f84f381 don't hold activity in fdroid manager
  • d57c44a Update app/src/fdroid/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt

📊 Changes

12 files changed (+201 additions, -3 deletions)

View changed files

📝 README.md (+5 -0)
📝 app/build.gradle.kts (+1 -0)
➕ app/src/fdroid/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt (+12 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+13 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManager.kt (+12 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+32 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+22 -1)
📝 app/src/main/res/values/strings.xml (+1 -0)
➕ app/src/standard/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt (+39 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+20 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+42 -0)
📝 gradle/libs.versions.toml (+2 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15381
https://bitwarden.atlassian.net/browse/PM-15383

📔 Objective

  • When the user is on the vault screen and has met the criteria for prompting for review (3 qualifying actions, auto fill/accessibility on) and the flag is on after 3 seconds prmpt for review
  • shows a toast in debug mode for ease of testing.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4455 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-15831-PM-15838-show-review-prompt` --- ### 📝 Commits (6) - [`0c03b26`](https://github.com/bitwarden/android/commit/0c03b26ef024405628c2898c561f9b17b7cb8cc5) PM-15383 and PM-15381 show the google play review prompt (if possible) and delay on vault screen - [`217b8aa`](https://github.com/bitwarden/android/commit/217b8aa2246155750fd08313fe7be1a5e2c0bf8a) fmt - [`6757fee`](https://github.com/bitwarden/android/commit/6757fee799b2a85889b4418f24ca630a96e4e8a5) always show the toast in debug mode when prompted - [`d5079b7`](https://github.com/bitwarden/android/commit/d5079b77d681ae0080a157beaab31e520d7e924c) pr feedback: update readme and remove google binary from fdroid build - [`f84f381`](https://github.com/bitwarden/android/commit/f84f381f021efc308c57fded04aa2d76ff080277) don't hold activity in fdroid manager - [`d57c44a`](https://github.com/bitwarden/android/commit/d57c44a1befdd8ca15308f060ef8c67ac236e0ab) Update app/src/fdroid/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt ### 📊 Changes **12 files changed** (+201 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+5 -0) 📝 `app/build.gradle.kts` (+1 -0) ➕ `app/src/fdroid/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt` (+12 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+13 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManager.kt` (+12 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+32 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+22 -1) 📝 `app/src/main/res/values/strings.xml` (+1 -0) ➕ `app/src/standard/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt` (+39 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+20 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+42 -0) 📝 `gradle/libs.versions.toml` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-15381 https://bitwarden.atlassian.net/browse/PM-15383 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - When the user is on the vault screen and has met the criteria for prompting for review (3 qualifying actions, auto fill/accessibility on) and the flag is on after 3 seconds prmpt for review - shows a toast in debug mode for ease of testing. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:52:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?