github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4440] [MERGED] PM-15599: Allow for custom TextToolbars #4947

New Issue
Closed
opened 2025-11-26 23:51:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4440
Author: @david-livefront
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @david-livefront

Base: main ← Head: PM-15599-updated-text-toolbar

📝 Commits (1)

  • 4aadad3 PM-15599: Allow for custom TextToolbars

📊 Changes

9 files changed (+298 additions, -97 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenHiddenPasswordField.kt (+18 -13)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt (+84 -43)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordFieldWithActions.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt (+82 -41)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextFieldWithActions.kt (+5 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/toolbar/BitwardenCutCopyTextToolbar.kt (+67 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/toolbar/BitwardenEmptyTextToolbar.kt (+24 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/model/TextToolbarType.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+2 -0)

📄 Description

🎟️ Tracking

PM-15599

📔 Objective

This PR overrides the default TextToolbar in order to ensure that all text that is cut or copied, is always treated as sensitive data.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4440 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-15599-updated-text-toolbar` --- ### 📝 Commits (1) - [`4aadad3`](https://github.com/bitwarden/android/commit/4aadad35c525d83a76b1ca10cb43a95d1b924cee) PM-15599: Allow for custom TextToolbars ### 📊 Changes **9 files changed** (+298 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenHiddenPasswordField.kt` (+18 -13) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt` (+84 -43) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordFieldWithActions.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt` (+82 -41) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextFieldWithActions.kt` (+5 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/toolbar/BitwardenCutCopyTextToolbar.kt` (+67 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/toolbar/BitwardenEmptyTextToolbar.kt` (+24 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/model/TextToolbarType.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-15599](https://bitwarden.atlassian.net/browse/PM-15599) ## 📔 Objective This PR overrides the default `TextToolbar` in order to ensure that all text that is cut or copied, is always treated as sensitive data. ## 📸 Screenshots | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/b32eae33-a2ad-4d01-931a-d5c7f8e5c2aa" width="300" /> | <video src="https://github.com/user-attachments/assets/670a4a3e-710f-4db4-b3f6-56941bdf7009" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-15599]: https://bitwarden.atlassian.net/browse/PM-15599?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4947
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?