github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4426] [MERGED] [PM-15609] Move FIDO2 origin validation logic to Fido2OriginManager #4938

New Issue
Closed
opened 2025-11-26 23:51:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4426
Author: @SaintPatrck
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-15609/fido2-origin-manager

📝 Commits (1)

  • 4e699ca [PM-15609] Move FIDO2 origin validation logic to Fido2OriginManager

📊 Changes

13 files changed (+643 additions, -462 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt (+15 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt (+0 -10)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+8 -139)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManager.kt (+32 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerImpl.kt (+172 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2ValidateOriginResult.kt (+37 -8)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensions.kt (+6 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+7 -5)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+10 -6)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt (+5 -270)
➕ app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerTest.kt (+332 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensionsTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+18 -14)

📄 Description

🎟️ Tracking

PM-15609

📔 Objective

Move the origin validation logic for FIDO2 credentials from Fido2CredentialManagerImpl to a new class, Fido2OriginManagerImpl. This refactoring improves code organization and separation of concerns.

Additionally, updates the Fido2CredentialManagerImpl to use the new Fido2OriginManager for origin validation.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4426 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-15609/fido2-origin-manager` --- ### 📝 Commits (1) - [`4e699ca`](https://github.com/bitwarden/android/commit/4e699cac7b8c524350e5fd9340d06e79e7db6512) [PM-15609] Move FIDO2 origin validation logic to Fido2OriginManager ### 📊 Changes **13 files changed** (+643 additions, -462 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt` (+15 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt` (+0 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+8 -139) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManager.kt` (+32 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerImpl.kt` (+172 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2ValidateOriginResult.kt` (+37 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensions.kt` (+6 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+7 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+10 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt` (+5 -270) ➕ `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerTest.kt` (+332 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensionsTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+18 -14) </details> ### 📄 Description ## 🎟️ Tracking PM-15609 ## 📔 Objective Move the origin validation logic for FIDO2 credentials from `Fido2CredentialManagerImpl` to a new class, `Fido2OriginManagerImpl`. This refactoring improves code organization and separation of concerns. Additionally, updates the `Fido2CredentialManagerImpl` to use the new `Fido2OriginManager` for origin validation. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/291fb231-ba36-42df-9714-1d2918c31200"/> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4938
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?