github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4418] [CLOSED] PM-15383 PM-15381 show review prompt if criteria met #4932

New Issue
Closed
opened 2025-11-26 23:51:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4418
Author: @dseverns-livefront
Created: 12/4/2024
Status: ❌ Closed

Base: main ← Head: PM-15383-PM-15381-show-review-prompt-if-criteria-met

📝 Commits (5)

  • d80993c PM-15380 set up storage and retrieval of data to determine if we show the review prompt and add areas where we record actions
  • ad59fff store per device instead of per user
  • e5c5c10 capture copies from generator screen as generator result
  • 0da5d9a working clipboard copy effect with listener
  • dc8b528 PM-15383 and PM-15381 show the google play review prompt (if possible) and delay on vault screen

📊 Changes

33 files changed (+768 additions, -22 deletions)

View changed files

📝 app/build.gradle.kts (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+31 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+36 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ReviewPromptManager.kt (+27 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ReviewPromptManagerImpl.kt (+73 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt (+5 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/di/GeneratorRepositoryModule.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt (+11 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+6 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt (+3 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/util/ClipboardDataEffect.kt (+42 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+13 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManager.kt (+12 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt (+41 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/util/IntExtensions.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+9 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+13 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+32 -1)

...and 13 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15381
https://bitwarden.atlassian.net/browse/PM-15383

📔 Objective

  • When the user is on the vault screen and has met the criteria for prompting for review (3 qualifying actions, auto fill/accessibility on) and the flag is on after 3 seconds prmpt for review
  • shows a toast in debug mode for ease of testing.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4418 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 12/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-15383-PM-15381-show-review-prompt-if-criteria-met` --- ### 📝 Commits (5) - [`d80993c`](https://github.com/bitwarden/android/commit/d80993cd4afb18825eab6b261209853d77e6cb6e) PM-15380 set up storage and retrieval of data to determine if we show the review prompt and add areas where we record actions - [`ad59fff`](https://github.com/bitwarden/android/commit/ad59fffb10e0be05032200075da8c03629873c71) store per device instead of per user - [`e5c5c10`](https://github.com/bitwarden/android/commit/e5c5c10ff610cc29fd664503e5b042472fe19e1c) capture copies from generator screen as generator result - [`0da5d9a`](https://github.com/bitwarden/android/commit/0da5d9afbfea43679142373ac437d1baa4f2174e) working clipboard copy effect with listener - [`dc8b528`](https://github.com/bitwarden/android/commit/dc8b528413705090b6d8f416bbf273812f143ead) PM-15383 and PM-15381 show the google play review prompt (if possible) and delay on vault screen ### 📊 Changes **33 files changed** (+768 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+31 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+36 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ReviewPromptManager.kt` (+27 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ReviewPromptManagerImpl.kt` (+73 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt` (+5 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/di/GeneratorRepositoryModule.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt` (+11 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+6 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt` (+3 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/util/ClipboardDataEffect.kt` (+42 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+13 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManager.kt` (+12 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt` (+41 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/util/IntExtensions.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+9 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+13 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+32 -1) _...and 13 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-15381 https://bitwarden.atlassian.net/browse/PM-15383 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - When the user is on the vault screen and has met the criteria for prompting for review (3 qualifying actions, auto fill/accessibility on) and the flag is on after 3 seconds prmpt for review - shows a toast in debug mode for ease of testing. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4932
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?