github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4391] [CLOSED] km/pm-15087-test #4917

New Issue
Closed
opened 2025-11-26 23:51:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4391
Author: @mzieniukbw
Created: 11/27/2024
Status: ❌ Closed

Base: main ← Head: km/pm-15087-test

📝 Commits (5)

  • 7a6b9a7 PM-15087: Update the device push token every 7 days
  • 6e91c43 PM-15087: Fix unit tests
  • 6b581ea PM-15087: Fix linting
  • 0ed7521 Merge branch 'main' into km/pm-15087
  • 6eec932 PM-15087: Trying to fix test

📊 Changes

3 files changed (+91 additions, -40 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt (+12 -13)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/PushManagerTest.kt (+73 -27)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/SpecialCircumstanceManagerTest.kt (+6 -0)

📄 Description

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4391 **Author:** [@mzieniukbw](https://github.com/mzieniukbw) **Created:** 11/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `km/pm-15087-test` --- ### 📝 Commits (5) - [`7a6b9a7`](https://github.com/bitwarden/android/commit/7a6b9a7633dfe0fd7e96b56a83efc780d1b001e2) PM-15087: Update the device push token every 7 days - [`6e91c43`](https://github.com/bitwarden/android/commit/6e91c432ab8ec90d55e066ce029d79b645200bc2) PM-15087: Fix unit tests - [`6b581ea`](https://github.com/bitwarden/android/commit/6b581ea29ee49c2c5ca0766050d36610a18ef312) PM-15087: Fix linting - [`0ed7521`](https://github.com/bitwarden/android/commit/0ed7521963b9a00bbf45665a3d0b3dc4f32d169d) Merge branch 'main' into km/pm-15087 - [`6eec932`](https://github.com/bitwarden/android/commit/6eec932e15b658e9a56df21f75d5942a8f6158c5) PM-15087: Trying to fix test ### 📊 Changes **3 files changed** (+91 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt` (+12 -13) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/PushManagerTest.kt` (+73 -27) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/SpecialCircumstanceManagerTest.kt` (+6 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4917
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?