github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4384] [MERGED] [BRE-443] - Fix bwwl Linting pre Deployment #4912

New Issue
Closed
opened 2025-11-26 23:51:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4384
Author: @Eeebru
Created: 11/25/2024
Status: ✅ Merged
Merged: 11/28/2024
Merged by: @Eeebru

Base: main ← Head: BRE-443-get-major-repos-to-bwwl-lint-passing-stage

📝 Commits (3)

  • ab2d886 [BRE-443] - Fix bwwl Linting pre Deployment
  • fa9ec75 Merge branch 'main' into BRE-443-get-major-repos-to-bwwl-lint-passing-stage
  • 85063d5 Merge branch 'main' into BRE-443-get-major-repos-to-bwwl-lint-passing-stage

📊 Changes

3 files changed (+3 additions, -1 deletions)

View changed files

📝 .github/workflows/crowdin-push.yml (+1 -1)
📝 .github/workflows/github-release.yml (+1 -0)
📝 .github/workflows/release-branch.yml (+1 -0)

📄 Description

🎟️ Tracking

📔 Objective

  • Updating worklfows to pass bwwl lint before deployment

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4384 **Author:** [@Eeebru](https://github.com/Eeebru) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 11/28/2024 **Merged by:** [@Eeebru](https://github.com/Eeebru) **Base:** `main` ← **Head:** `BRE-443-get-major-repos-to-bwwl-lint-passing-stage` --- ### 📝 Commits (3) - [`ab2d886`](https://github.com/bitwarden/android/commit/ab2d886d6e8f957fe3998e52f7824148d1053ffb) [BRE-443] - Fix bwwl Linting pre Deployment - [`fa9ec75`](https://github.com/bitwarden/android/commit/fa9ec75e2bc68d18d9621bf18206dafda0dcdd86) Merge branch 'main' into BRE-443-get-major-repos-to-bwwl-lint-passing-stage - [`85063d5`](https://github.com/bitwarden/android/commit/85063d5fff9fbc560be7cac9d55ea7f98f5373a9) Merge branch 'main' into BRE-443-get-major-repos-to-bwwl-lint-passing-stage ### 📊 Changes **3 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/crowdin-push.yml` (+1 -1) 📝 `.github/workflows/github-release.yml` (+1 -0) 📝 `.github/workflows/release-branch.yml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking - https://bitwarden.atlassian.net/browse/BRE-443 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Updating worklfows to pass `bwwl lint` before deployment <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?