github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4383] [MERGED] PM-15147 - Design Audit - Master Password Guidance Screen #4911

New Issue
Closed
opened 2025-11-26 23:51:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:51:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4383
Author: @phil-livefront
Created: 11/25/2024
Status: ✅ Merged
Merged: 12/2/2024
Merged by: @phil-livefront

Base: main ← Head: phil/PM-15147-design-audit-master-password-guidance-screen

📝 Commits (6)

  • 11c8711 PM-15147 - Design Audit - Master Password Guidance Screen
  • 8fb81e9 Merge branch 'main' into phil/PM-15147-design-audit-master-password-guidance-screen
  • 63ce644 fix linter errors
  • 47c5e86 fix texts and abstract missed strings to resource
  • 79a9d56 Merge branch 'main' into phil/PM-15147-design-audit-master-password-guidance-screen
  • c628d2f PR comments

📊 Changes

7 files changed (+171 additions, -130 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+108 -114)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt (+22 -7)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCardSmall.kt (+6 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/color/BitwardenCardColors.kt (+14 -6)
📝 app/src/main/res/values/strings.xml (+13 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreenTest.kt (+3 -1)

📄 Description

🎟️ Tracking

PM-15147

📔 Objective

  • Align Text: Center-align the title and subtitle text across relevant components.
  • Design Updates: Update the content block styling to match the Figma designs for V3.
  • Background Changes: Remove the blue background from the "What makes a password strong?" block.
  • Registration Screen Adjustments: Remove the blue content background from the CompleteRegistrationScreen where the MasterPasswordGuidanceScreen is launched. This follows iOS design changes. Retain the border color to minimize deviations.
  • Action Card Enhancement: Modify BitwardenActionCard to include an optional dismiss action, supporting scenarios like the MasterPasswordGuidanceScreen where no dismiss action is required.

📸 Screenshots

CompleteRegistration
MasterPasswordGuidanceScreen

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4383 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 12/2/2024 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-15147-design-audit-master-password-guidance-screen` --- ### 📝 Commits (6) - [`11c8711`](https://github.com/bitwarden/android/commit/11c87116330a15fbfa82e44415a3eac0a4c81134) PM-15147 - Design Audit - Master Password Guidance Screen - [`8fb81e9`](https://github.com/bitwarden/android/commit/8fb81e9db57e666f361fca716e9a6c12765357aa) Merge branch 'main' into phil/PM-15147-design-audit-master-password-guidance-screen - [`63ce644`](https://github.com/bitwarden/android/commit/63ce644749c7900502be3dbc0dcd0845c228a8e4) fix linter errors - [`47c5e86`](https://github.com/bitwarden/android/commit/47c5e8609a1ca1b3dc9a7033c1d4e01c46112252) fix texts and abstract missed strings to resource - [`79a9d56`](https://github.com/bitwarden/android/commit/79a9d56ffc201b4646ab734755ac2da959936004) Merge branch 'main' into phil/PM-15147-design-audit-master-password-guidance-screen - [`c628d2f`](https://github.com/bitwarden/android/commit/c628d2f07157780bbd672664a410fb870d6103ed) PR comments ### 📊 Changes **7 files changed** (+171 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+108 -114) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt` (+22 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCardSmall.kt` (+6 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/color/BitwardenCardColors.kt` (+14 -6) 📝 `app/src/main/res/values/strings.xml` (+13 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreenTest.kt` (+3 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-15147](https://bitwarden.atlassian.net/browse/PM-15147) ## 📔 Objective - Align Text: Center-align the title and subtitle text across relevant components. - Design Updates: Update the content block styling to match the Figma designs for V3. - Background Changes: Remove the blue background from the "What makes a password strong?" block. - Registration Screen Adjustments: Remove the blue content background from the CompleteRegistrationScreen where the MasterPasswordGuidanceScreen is launched. This follows iOS design changes. Retain the border color to minimize deviations. - Action Card Enhancement: Modify `BitwardenActionCard` to include an optional dismiss action, supporting scenarios like the MasterPasswordGuidanceScreen where no dismiss action is required. ## 📸 Screenshots ![CompleteRegistration](https://github.com/user-attachments/assets/0814830f-f105-43e3-8167-3cceaf76d244) ![MasterPasswordGuidanceScreen](https://github.com/user-attachments/assets/53c4be9c-bd6c-43d5-abd2-c5ede819626b) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-15147]: https://bitwarden.atlassian.net/browse/PM-15147?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:51:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?