github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4335] [MERGED] [PM-15050] Track vault registration for CXP export in settings #4871

New Issue
Closed
opened 2025-11-26 23:50:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:50:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4335
Author: @SaintPatrck
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/22/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-15050/cxp-export-registration-prefs

📝 Commits (5)

  • 92e2a84 [PM-15050] Track vault registration for CXP export in settings
  • 3325026 Merge remote-tracking branch 'origin/main' into PM-15050/cxp-export-registration-prefs
  • 3c22e2d Make disk source rVal nullable
  • 2c58301 Allow null for isRegistered in storeVaultRegisteredForExport
  • b05d47e Clear data in fake settings disk source

📊 Changes

7 files changed (+188 additions, -8 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+23 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+21 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt (+34 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt (+28 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+48 -7)

📄 Description

🎟️ Tracking

PM-15050

📔 Objective

Add a new setting to track whether or not a user has previously registered their vault for export via the credential exchange protocol.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4335 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/22/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-15050/cxp-export-registration-prefs` --- ### 📝 Commits (5) - [`92e2a84`](https://github.com/bitwarden/android/commit/92e2a846be5686fc0cf867400c575cb13ee40598) [PM-15050] Track vault registration for CXP export in settings - [`3325026`](https://github.com/bitwarden/android/commit/332502670889eeb3b0bf3a9b43b08e49c4526ce2) Merge remote-tracking branch 'origin/main' into PM-15050/cxp-export-registration-prefs - [`3c22e2d`](https://github.com/bitwarden/android/commit/3c22e2dd2dd59374e1b04d0c6cfddb47f8f0afe6) Make disk source rVal nullable - [`2c58301`](https://github.com/bitwarden/android/commit/2c5830147d6467a5f460540096c082373800679d) Allow null for isRegistered in storeVaultRegisteredForExport - [`b05d47e`](https://github.com/bitwarden/android/commit/b05d47e997638a97a48bba7f6f47fa4817b51914) Clear data in fake settings disk source ### 📊 Changes **7 files changed** (+188 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+23 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+21 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt` (+34 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt` (+28 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+48 -7) </details> ### 📄 Description ## 🎟️ Tracking PM-15050 ## 📔 Objective Add a new setting to track whether or not a user has previously registered their vault for export via the credential exchange protocol. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:50:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4871
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?