github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6835] PM-27234: feat: jit password v2 encryption #48458

New Issue
Open
opened 2026-04-26 16:09:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 16:09:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6835
Author: @david-livefront
Created: 4/24/2026
Status: 🔄 Open

Base: main ← Head: PM-27234-jit-password-v2-encryption

📝 Commits (2)

  • 56b6422 Split setPassword flow
  • 0ad8827 PM-27234: jit password v2 encryption

📊 Changes

10 files changed (+1035 additions, -381 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSource.kt (+16 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt (+29 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+192 -51)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt (+22 -5)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WrappedAccountCryptographicStateExtensions.kt (+41 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt (+59 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+534 -323)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensionsTest.kt (+85 -2)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WrappedAccountCryptographicStateExtensionsTest.kt (+54 -0)

📄 Description

🎟️ Tracking

PM-27234

📔 Objective

This PR adds the V2 Encryption flow for set password (JIT PAssword). Additional changes were made to fork the setPassword from the updatePassword logic.

This PR is broken into 2 commits:

  • Commit 1 splits the setPassword flow into 2 distinct paths based on the forcePasswordResetReason and simplifies the flows where possible (removing the need to hash the passwords).
  • Commit 2 is where the V2 Encryption flow is actually added.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6835 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `PM-27234-jit-password-v2-encryption` --- ### 📝 Commits (2) - [`56b6422`](https://github.com/bitwarden/android/commit/56b6422fd84f157707e5ad24ed4212df60df3f62) Split setPassword flow - [`0ad8827`](https://github.com/bitwarden/android/commit/0ad882799eaeaa06f4cfb37157ede5662a81679e) PM-27234: jit password v2 encryption ### 📊 Changes **10 files changed** (+1035 additions, -381 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSource.kt` (+16 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt` (+29 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+192 -51) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt` (+22 -5) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WrappedAccountCryptographicStateExtensions.kt` (+41 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt` (+59 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+534 -323) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensionsTest.kt` (+85 -2) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WrappedAccountCryptographicStateExtensionsTest.kt` (+54 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-27234](https://bitwarden.atlassian.net/browse/PM-27234) ## 📔 Objective This PR adds the V2 Encryption flow for set password (JIT PAssword). Additional changes were made to fork the `setPassword` from the `updatePassword` logic. This PR is broken into 2 commits: * Commit 1 splits the `setPassword` flow into 2 distinct paths based on the `forcePasswordResetReason` and simplifies the flows where possible (removing the need to hash the passwords). * Commit 2 is where the V2 Encryption flow is actually added. [PM-27234]: https://bitwarden.atlassian.net/browse/PM-27234?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 16:09:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#48458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?