github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6740] [MERGED] BWA-224: bug: Add sort order for Authenticator items #48437

New Issue
Closed
opened 2026-04-26 16:05:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 16:05:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6740
Author: @david-livefront
Created: 3/30/2026
Status: ✅ Merged
Merged: 3/30/2026
Merged by: @david-livefront

Base: main ← Head: BWA-224-authenticator-sort

📝 Commits (1)

  • 60432d2 BWA-224: Add sort order for Authenticator items

📊 Changes

11 files changed (+231 additions, -28 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt (+3 -3)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt (+3 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/SharedVerificationCodesStateExtensions.kt (+4 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/SharedCodesDisplayState.kt (+1 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/SharedCodesDisplayStateExtensions.kt (+15 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/VerificationCodeDisplayItemExtensions.kt (+15 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreenTest.kt (+1 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/search/ItemSearchViewModelTest.kt (+1 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/SharedVerificationCodesStateTest.kt (+28 -24)
➕ authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/SharedCodesAccountSectionExtensionsTest.kt (+67 -0)
➕ authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/VerificationCodeDisplayItemExtensionsTest.kt (+93 -0)

📄 Description

🎟️ Tracking

BWA-224

📔 Objective

This PR adds sorting to the authenticator to match the logic in the PasswordManager. We sort alphabetically.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6740 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/30/2026 **Status:** ✅ Merged **Merged:** 3/30/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `BWA-224-authenticator-sort` --- ### 📝 Commits (1) - [`60432d2`](https://github.com/bitwarden/android/commit/60432d28740462258bd29d75fc01a45c9e6012b9) BWA-224: Add sort order for Authenticator items ### 📊 Changes **11 files changed** (+231 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt` (+3 -3) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt` (+3 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/SharedVerificationCodesStateExtensions.kt` (+4 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/SharedCodesDisplayState.kt` (+1 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/SharedCodesDisplayStateExtensions.kt` (+15 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/VerificationCodeDisplayItemExtensions.kt` (+15 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreenTest.kt` (+1 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/search/ItemSearchViewModelTest.kt` (+1 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/SharedVerificationCodesStateTest.kt` (+28 -24) ➕ `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/SharedCodesAccountSectionExtensionsTest.kt` (+67 -0) ➕ `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/util/VerificationCodeDisplayItemExtensionsTest.kt` (+93 -0) </details> ### 📄 Description ## 🎟️ Tracking [BWA-224](https://bitwarden.atlassian.net/browse/BWA-224) ## 📔 Objective This PR adds sorting to the authenticator to match the logic in the PasswordManager. We sort alphabetically. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/de82dac5-307b-4ce1-8151-08bd339d3218" /> | <img width="350" src="https://github.com/user-attachments/assets/c9cc6bf3-0101-4d82-b55d-93e3fd32f3e9" /> | [BWA-224]: https://bitwarden.atlassian.net/browse/BWA-224?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 16:05:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#48437