github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4285] [MERGED] [PM-11598] GitHub Release Workflow #4833

New Issue
Closed
opened 2025-11-26 23:50:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:50:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4285
Author: @vvolkgang
Created: 11/11/2024
Status: ✅ Merged
Merged: 11/13/2024
Merged by: @vvolkgang

Base: main ← Head: release-workflows

📝 Commits (6)

  • b134df3 Release notes script, for releases with cherry picks
  • 5a9a4b7 Merge branch 'main' into release-workflows
  • 2c47032 Addd github release workflow
  • 13cae98 pin runner os version
  • 4dd6e96 Output release url to summary
  • 037f2d1 Add input to control branch protection

📊 Changes

2 files changed (+175 additions, -0 deletions)

View changed files

➕ .github/workflows/github-release.yml (+127 -0)
➕ scripts/release-notes.sh (+48 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11598

📔 Objective

Adds a workflow to create github releases based off a build action Run, by creating a new GitHub Release with automated release notes, uploading the artifacts from the provided run ID and appending run URL to the release description.

⚠️ Currently, version name and number have to be manually provided, this will be automated after build.yml is improved to upload a version-info.json with that info.

Additionally, adds a release-notes.sh script that may be used for release branches with cherry picks directly pushed without a PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4285 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 11/11/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `release-workflows` --- ### 📝 Commits (6) - [`b134df3`](https://github.com/bitwarden/android/commit/b134df3753f516f3bb41ce87112beb4b534f7c13) Release notes script, for releases with cherry picks - [`5a9a4b7`](https://github.com/bitwarden/android/commit/5a9a4b72ca4824979d696df49ee4aa49a566dd5f) Merge branch 'main' into release-workflows - [`2c47032`](https://github.com/bitwarden/android/commit/2c470325990d849903a018abbc8e14adaa85c333) Addd github release workflow - [`13cae98`](https://github.com/bitwarden/android/commit/13cae984ab03ac19eeffa78643359b6b29429126) pin runner os version - [`4dd6e96`](https://github.com/bitwarden/android/commit/4dd6e96196370310210403ec7ec7eb1a6bbad4ca) Output release url to summary - [`037f2d1`](https://github.com/bitwarden/android/commit/037f2d1f2f8b15319268d35c1f2871b950c1e71b) Add input to control branch protection ### 📊 Changes **2 files changed** (+175 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/github-release.yml` (+127 -0) ➕ `scripts/release-notes.sh` (+48 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-11598 ## 📔 Objective Adds a workflow to create github releases based off a build action Run, by creating a new GitHub Release with automated release notes, uploading the artifacts from the provided run ID and appending run URL to the release description. :warning: Currently, version name and number have to be manually provided, this will be automated after build.yml is improved to upload a `version-info.json` with that info. Additionally, adds a release-notes.sh script that may be used for release branches with cherry picks directly pushed without a PR. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:50:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?