github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6441] [MERGED] [PM-31445] Fix minor KDoc typos and wording issues. #48187

New Issue
Closed
opened 2026-04-26 15:45:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 15:45:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6441
Author: @ruyut
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @david-livefront

Base: main ← Head: main

📝 Commits (4)

  • a97bc30 Fix typo in isActiveWithPasswordCredentials documentation
  • 463dadb Fix Error KDoc wording for auth request creation
  • 28fec51 Fix typo in auth request approval documentation
  • 3d23a2d Merge branch 'main' into main

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/model/CreateAuthRequestResult.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/CipherViewExtensions.kt (+1 -1)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR addresses some minor typos in comments.

📸 Screenshots

N/A — no UI changes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6441 **Author:** [@ruyut](https://github.com/ruyut) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`a97bc30`](https://github.com/bitwarden/android/commit/a97bc30a6b0c32ac0655392de46d593294cf5753) Fix typo in isActiveWithPasswordCredentials documentation - [`463dadb`](https://github.com/bitwarden/android/commit/463dadb009a5dbfb795b69a33db9e73a4ef427a1) Fix Error KDoc wording for auth request creation - [`28fec51`](https://github.com/bitwarden/android/commit/28fec51e8effa1e460bbdbf82d791d7e29eaea80) Fix typo in auth request approval documentation - [`3d23a2d`](https://github.com/bitwarden/android/commit/3d23a2d07c032dfddfa78fbbce32ec22fa48dec4) Merge branch 'main' into main ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/model/CreateAuthRequestResult.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/CipherViewExtensions.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking N/A <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective This PR addresses some minor typos in comments. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots N/A — no UI changes. <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 15:45:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#48187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?