github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4248] [MERGED] PM-11753: Vault flows should listen to vault onlock state to ensure d… #4800

New Issue
Closed
opened 2025-11-26 23:49:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4248
Author: @david-livefront
Created: 11/6/2024
Status: ✅ Merged
Merged: 11/6/2024
Merged by: @david-livefront

Base: release/hotfix-v2024.11.1 ← Head: PM-11753-vault-infinite-loading

📝 Commits (1)

  • a2244e8 PM-11753: Vault flows should listen to vault onlock state to ensure data is properly updated

📊 Changes

4 files changed (+146 additions, -7 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensions.kt (+33 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+24 -6)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensionsTest.kt (+69 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+20 -1)

📄 Description

🎟️ Tracking

PM-11753

📔 Objective

This PR addresses an issue in the vault where the state flows get cleared on vault-lock but do not re-emit when the vault is unlocked again. This leads to an infinite loading. state

This tries to fix it by creating a new flow that also listens to the vaultUnlockFlow.
mutableStateFlow on the VaultRepository will listen to the observeWhenSubscribedAndUnlocked and call the observer on unlock

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4248 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 11/6/2024 **Status:** ✅ Merged **Merged:** 11/6/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `release/hotfix-v2024.11.1` ← **Head:** `PM-11753-vault-infinite-loading` --- ### 📝 Commits (1) - [`a2244e8`](https://github.com/bitwarden/android/commit/a2244e8cc3ebc592abcd09ac120f00ffbeb84efe) PM-11753: Vault flows should listen to vault onlock state to ensure data is properly updated ### 📊 Changes **4 files changed** (+146 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensions.kt` (+33 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+24 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensionsTest.kt` (+69 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+20 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-11753](https://bitwarden.atlassian.net/browse/PM-11753) ## 📔 Objective This PR addresses an issue in the vault where the state flows get cleared on vault-lock but do not re-emit when the vault is unlocked again. This leads to an infinite loading. state This tries to fix it by creating a new flow that also listens to the `vaultUnlockFlow`. mutableStateFlow on the VaultRepository will listen to the `observeWhenSubscribedAndUnlocked` and call the observer on unlock ## 📸 Screenshots | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/83fffe55-3681-406f-b599-8f8289ab14c9" width="300" /> | <video src="https://github.com/user-attachments/assets/34c3be19-6871-4887-b306-d13ec0dc3417" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-11753]: https://bitwarden.atlassian.net/browse/PM-11753?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4800
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?