github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6121] [MERGED] Reduce verbosity in reviewing-changes skill for clean PRs #47935

New Issue
Closed
opened 2026-04-26 15:28:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 15:28:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6121
Author: @SaintPatrck
Created: 11/4/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @SaintPatrck

Base: main ← Head: skill/reviewing-changes-reduce-verbosity

📝 Commits (2)

  • a5985ad Reduce verbosity in reviewing-changes skill for clean PRs
  • 22e9d30 Address review feedback: consolidate principles and add context

📊 Changes

4 files changed (+245 additions, -29 deletions)

View changed files

📝 .claude/skills/reviewing-changes/SKILL.md (+30 -0)
📝 .claude/skills/reviewing-changes/checklists/refactoring.md (+88 -28)
📝 .claude/skills/reviewing-changes/examples/review-outputs.md (+126 -0)
📝 .claude/skills/reviewing-changes/reference/review-psychology.md (+1 -1)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR reduces excessive verbosity in the reviewing-changes skill when reviewing clean PRs with no issues.

Problem:
PR #6117 received an ~800 token review with elaborate praise sections (Key Strengths, Changes, Code Quality & Architecture, etc.) when no issues were found. The expected output should have been ~30 tokens: "APPROVE - Clean refactoring".

Root Causes:

  • No explicit guidance for "clean PR" scenario
  • Positive feedback rules understated in skill documentation
  • Contradictory verbose example in refactoring checklist
  • Insufficient emphasis on anti-patterns for excessive praise

Solution:
Modified 4 skill files to establish "minimal reviews for clean PRs" as the primary principle:

  1. SKILL.md: Added "Special Case: Clean PRs" section with explicit 2-3 line approval format; made "minimal reviews" the first core principle
  2. review-psychology.md: Elevated brevity guidance to first directive position
  3. review-outputs.md: Added Example 7 showing actual PR #6117 verbose output as anti-pattern with correct minimal approach
  4. refactoring.md: Replaced single verbose example with two distinct examples (with issues vs clean)

Expected Impact:

  • 70-90% token reduction for clean PRs (800 → 30-100 tokens)
  • Maintains comprehensive reviews for PRs with actual issues
  • Reduces noise in PR conversations
  • Faster approvals for good work
  • Clearer expectations for appropriate review verbosity

Testing:
The skill should now produce minimal ~30 token approvals for clean PRs while maintaining detailed inline comments with collapsible <details> tags for PRs with actual issues.

Note: This is a documentation-only change to the .claude/skills/reviewing-changes/ skill. No application code is modified.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6121 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 11/4/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `skill/reviewing-changes-reduce-verbosity` --- ### 📝 Commits (2) - [`a5985ad`](https://github.com/bitwarden/android/commit/a5985ad427a78b95f2c167bb37e8bbdfe2d133e4) Reduce verbosity in reviewing-changes skill for clean PRs - [`22e9d30`](https://github.com/bitwarden/android/commit/22e9d300ca6b883c9774920d6c44e597b6f43a2f) Address review feedback: consolidate principles and add context ### 📊 Changes **4 files changed** (+245 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `.claude/skills/reviewing-changes/SKILL.md` (+30 -0) 📝 `.claude/skills/reviewing-changes/checklists/refactoring.md` (+88 -28) 📝 `.claude/skills/reviewing-changes/examples/review-outputs.md` (+126 -0) 📝 `.claude/skills/reviewing-changes/reference/review-psychology.md` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR reduces excessive verbosity in the `reviewing-changes` skill when reviewing clean PRs with no issues. **Problem:** PR #6117 received an ~800 token review with elaborate praise sections (Key Strengths, Changes, Code Quality & Architecture, etc.) when no issues were found. The expected output should have been ~30 tokens: `"APPROVE - Clean refactoring"`. **Root Causes:** - No explicit guidance for "clean PR" scenario - Positive feedback rules understated in skill documentation - Contradictory verbose example in refactoring checklist - Insufficient emphasis on anti-patterns for excessive praise **Solution:** Modified 4 skill files to establish "minimal reviews for clean PRs" as the primary principle: 1. **SKILL.md**: Added "Special Case: Clean PRs" section with explicit 2-3 line approval format; made "minimal reviews" the first core principle 2. **review-psychology.md**: Elevated brevity guidance to first directive position 3. **review-outputs.md**: Added Example 7 showing actual PR #6117 verbose output as anti-pattern with correct minimal approach 4. **refactoring.md**: Replaced single verbose example with two distinct examples (with issues vs clean) **Expected Impact:** - 70-90% token reduction for clean PRs (800 → 30-100 tokens) - Maintains comprehensive reviews for PRs with actual issues - Reduces noise in PR conversations - Faster approvals for good work - Clearer expectations for appropriate review verbosity **Testing:** The skill should now produce minimal ~30 token approvals for clean PRs while maintaining detailed inline comments with collapsible `<details>` tags for PRs with actual issues. --- **Note:** This is a documentation-only change to the `.claude/skills/reviewing-changes/` skill. No application code is modified. --- ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 15:28:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#47935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?