github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4229] [MERGED] PM-14458: Update notifications permissions request #4789

New Issue
Closed
opened 2025-11-26 23:49:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4229
Author: @david-livefront
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @david-livefront

Base: main ← Head: PM-14458-notifications-permission

📝 Commits (1)

  • 3dde55c PM-14458: Update notifications permissions request

📊 Changes

13 files changed (+369 additions, -89 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt (+23 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreen.kt (+100 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsViewModel.kt (+13 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsScreen.kt (+3 -17)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+0 -32)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+0 -5)
➕ app/src/main/res/drawable-night/img_2fa.xml (+73 -0)
➕ app/src/main/res/drawable/img_2fa.xml (+73 -0)
📝 app/src/main/res/values/strings.xml (+4 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreenTest.kt (+65 -8)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsViewModelTest.kt (+15 -9)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+0 -12)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+0 -1)

📄 Description

🎟️ Tracking

PM-14458

📔 Objective

This PR updates the way we request the notifications permission. Instead of prompting in the vault screen with no context, we not prompt in the Pending Requests Screen.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4229 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-14458-notifications-permission` --- ### 📝 Commits (1) - [`3dde55c`](https://github.com/bitwarden/android/commit/3dde55c56fda272c3da67362589bfe7b226ea38c) PM-14458: Update notifications permissions request ### 📊 Changes **13 files changed** (+369 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt` (+23 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreen.kt` (+100 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsViewModel.kt` (+13 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsScreen.kt` (+3 -17) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+0 -32) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+0 -5) ➕ `app/src/main/res/drawable-night/img_2fa.xml` (+73 -0) ➕ `app/src/main/res/drawable/img_2fa.xml` (+73 -0) 📝 `app/src/main/res/values/strings.xml` (+4 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreenTest.kt` (+65 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsViewModelTest.kt` (+15 -9) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+0 -12) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+0 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-14458](https://bitwarden.atlassian.net/browse/PM-14458) ## 📔 Objective This PR updates the way we request the notifications permission. Instead of prompting in the vault screen with no context, we not prompt in the Pending Requests Screen. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/f51c20e5-775d-42f2-a1cf-e837bc76a526" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-14458]: https://bitwarden.atlassian.net/browse/PM-14458?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?