github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6062] [MERGED] [PM-27092] Changing screen capture flow from event based to state based on Authenticator #47881

New Issue
Closed
opened 2026-04-26 15:25:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 15:25:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6062
Author: @aj-rosado
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @aj-rosado

Base: main ← Head: PM-27092/fix-orientation-change-resets-screenshot-flag

📝 Commits (4)

  • 99b2fd1 Changing screen capture flow from event based to state based on Authenticator
  • d8905ee using action to update state on MainViewModel
  • b21c4a7 using sendAction and passing whole action to handler
  • 963ea80 Merge branch 'main' into PM-27092/fix-orientation-change-resets-screenshot-flag

📊 Changes

3 files changed (+50 additions, -15 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/MainActivity.kt (+3 -6)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/MainViewModel.kt (+26 -7)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/MainViewModelTest.kt (+21 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27092

📔 Objective

Changing orientation is cleaning the flags, changing isScreenCaptureAllowed to state makes this work properly and consistent with the password manager implementation.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6062 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-27092/fix-orientation-change-resets-screenshot-flag` --- ### 📝 Commits (4) - [`99b2fd1`](https://github.com/bitwarden/android/commit/99b2fd18cbba1a70eefa70a9b84863eff3d7c2f5) Changing screen capture flow from event based to state based on Authenticator - [`d8905ee`](https://github.com/bitwarden/android/commit/d8905eefbe9ace2217be3ac104c6061f61c7c162) using action to update state on MainViewModel - [`b21c4a7`](https://github.com/bitwarden/android/commit/b21c4a7b43a37f2f6d02e94fde4a4ca7c50e2d96) using sendAction and passing whole action to handler - [`963ea80`](https://github.com/bitwarden/android/commit/963ea8022e1091a959cc0b3b94b63cd5533e448a) Merge branch 'main' into PM-27092/fix-orientation-change-resets-screenshot-flag ### 📊 Changes **3 files changed** (+50 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/MainActivity.kt` (+3 -6) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/MainViewModel.kt` (+26 -7) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/MainViewModelTest.kt` (+21 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-27092 ## 📔 Objective Changing orientation is cleaning the flags, changing `isScreenCaptureAllowed` to state makes this work properly and consistent with the password manager implementation. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 15:25:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#47881
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?