[PR #4228] [MERGED] BITAU-200 Log non-fatal authenticator bridge errors #4788

New Issue

GiteaMirror · 2025-11-26T23:49:46-06:00

GiteaMirror commented

2025-11-26 23:49:46 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4228
Author: @ahaisting-livefront
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/12/2024
Merged by: @david-livefront

Base: main ← Head: authenticator-bridge-non-fatals

📝 Commits (4)

74f7c49 BITAU-200 Log non-fatal authenticator bridge errors
df96e1e Replace custom exception with IllegalStateException
f58e5da Merge remote-tracking branch 'origin/main' into authenticator-bridge-non-fatals
4a9045f Handle TOTP decryption failure gracefully

📊 Changes

1 file changed (+27 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorImpl.kt (+27 -3)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-200

📔 Objective

Log a few non-fatal errors in the authenticator bridge sync process.

📸 Screenshots

N/A

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4228 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/12/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `authenticator-bridge-non-fatals` --- ### 📝 Commits (4) - [`74f7c49`](https://github.com/bitwarden/android/commit/74f7c49154aca2a583903fc2c8491dccf5f83f18) BITAU-200 Log non-fatal authenticator bridge errors - [`df96e1e`](https://github.com/bitwarden/android/commit/df96e1e163cc9229318efe47bf71951dfc34e4a9) Replace custom exception with IllegalStateException - [`f58e5da`](https://github.com/bitwarden/android/commit/f58e5daae821c2fe1690577d8ceb053e05a2c718) Merge remote-tracking branch 'origin/main' into authenticator-bridge-non-fatals - [`4a9045f`](https://github.com/bitwarden/android/commit/4a9045f540e5e4a87cabeeebb9aacba8fc9df461) Handle TOTP decryption failure gracefully ### 📊 Changes **1 file changed** (+27 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorImpl.kt` (+27 -3) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-200 ## 📔 Objective Log a few non-fatal errors in the authenticator bridge sync process. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:49:46 -06:00

GiteaMirror closed this issue