github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5980] [MERGED] PM-26594: Move the QrCodeAnalyzer to the UI module #47807

New Issue
Closed
opened 2026-04-26 15:22:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 15:22:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5980
Author: @david-livefront
Created: 10/7/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @david-livefront

Base: main ← Head: PM-26594-common-qr-code-analyzer

📝 Commits (1)

  • baa4b42 PM-26594: Move the QrCodeAnalyzer to the UI module

📊 Changes

13 files changed (+19 additions, -126 deletions)

View changed files

📝 app/build.gradle.kts (+0 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt (+2 -2)
➖ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/util/QrCodeAnalyzerImpl.kt (+0 -73)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreenTest.kt (+1 -1)
📝 authenticator/build.gradle.kts (+0 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt (+2 -2)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/util/QrCodeAnalyzer.kt (+0 -16)
➖ authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/FakeQrCodeAnalyzer.kt (+0 -22)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreenTest.kt (+1 -0)
📝 ui/build.gradle.kts (+3 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/feature/qrcodescan/util/QrCodeAnalyzer.kt (+1 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/feature/qrcodescan/util/QrCodeAnalyzerImpl.kt (+8 -6)
📝 ui/src/testFixtures/kotlin/com/bitwarden/ui/platform/feature/qrcodescan/util/FakeQrCodeAnalyzer.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-26594

📔 Objective

This PR moves the QrCodeAnalyzer to the common UI module so it can be reused in both Password Manager and Authenticator.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5980 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/7/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-26594-common-qr-code-analyzer` --- ### 📝 Commits (1) - [`baa4b42`](https://github.com/bitwarden/android/commit/baa4b429c6441e6323d3f0f40775eb9a4679c986) PM-26594: Move the QrCodeAnalyzer to the UI module ### 📊 Changes **13 files changed** (+19 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+0 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt` (+2 -2) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/util/QrCodeAnalyzerImpl.kt` (+0 -73) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreenTest.kt` (+1 -1) 📝 `authenticator/build.gradle.kts` (+0 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt` (+2 -2) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/util/QrCodeAnalyzer.kt` (+0 -16) ➖ `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/FakeQrCodeAnalyzer.kt` (+0 -22) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreenTest.kt` (+1 -0) 📝 `ui/build.gradle.kts` (+3 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/qrcodescan/util/QrCodeAnalyzer.kt` (+1 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/qrcodescan/util/QrCodeAnalyzerImpl.kt` (+8 -6) 📝 `ui/src/testFixtures/kotlin/com/bitwarden/ui/platform/feature/qrcodescan/util/FakeQrCodeAnalyzer.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-26594](https://bitwarden.atlassian.net/browse/PM-26594) ## 📔 Objective This PR moves the `QrCodeAnalyzer` to the common UI module so it can be reused in both Password Manager and Authenticator. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-26594]: https://bitwarden.atlassian.net/browse/PM-26594?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 15:22:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#47807
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?