github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4214] [MERGED] [PM-11753] Listening to vaultUnlock state on mutableCiphers, folders, collections and send state flow #4779

New Issue
Closed
opened 2025-11-26 23:49:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4214
Author: @aj-rosado
Created: 10/31/2024
Status: ✅ Merged
Merged: 11/8/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-11753/vault-stuck-loading-after-unlock

📝 Commits (2)

  • 4654917 Listening to vaultUnlock state on mutable ciphers, domain, folders, collections, send state flow
  • 85038df Addressed pr comments

📊 Changes

4 files changed (+151 additions, -8 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensions.kt (+34 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+28 -7)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensionsTest.kt (+69 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+20 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11753

📔 Objective

In some instances the vault gets stuck on an infinite loading.
This is caused by some scenarios when the app is on background and the vault gets locked the requirements to emit on observeWhenSubscribedAndLoggedIn are not met causing the observer to not be called anymore.

This tries to fix it by creating a new flow that also listens to the vaultUnlockFlow.
mutableStateFlow on the VaultRepository will listen to the observeWhenSubscribedAndUnlocked and call the observer on unlock

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4214 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 11/8/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-11753/vault-stuck-loading-after-unlock` --- ### 📝 Commits (2) - [`4654917`](https://github.com/bitwarden/android/commit/46549172f84c11841ddc305d2dd31711ddc9e78e) Listening to vaultUnlock state on mutable ciphers, domain, folders, collections, send state flow - [`85038df`](https://github.com/bitwarden/android/commit/85038df50cf293ec912772496f09db34106d5d18) Addressed pr comments ### 📊 Changes **4 files changed** (+151 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensions.kt` (+34 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+28 -7) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensionsTest.kt` (+69 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+20 -1) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-11753 ## 📔 Objective In some instances the vault gets stuck on an infinite loading. This is caused by some scenarios when the app is on background and the vault gets locked the requirements to emit on `observeWhenSubscribedAndLoggedIn` are not met causing the observer to not be called anymore. This tries to fix it by creating a new flow that also listens to the `vaultUnlockFlow`. mutableStateFlow on the VaultRepository will listen to the `observeWhenSubscribedAndUnlocked` and call the observer on unlock ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?