github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 13:14:35 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4181] [MERGED] PM-14200: Update the eyebrows throughout the app #4755

New Issue
Closed
opened 2025-11-26 23:49:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4181
Author: @david-livefront
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @david-livefront

Base: main ← Head: PM-14200-app-eyebrows

📝 Commits (1)

  • 606740a PM-14200: Update the eyebrows throughout the app

📊 Changes

11 files changed (+79 additions, -164 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/header/BitwardenListHeaderText.kt (+17 -6)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/header/BitwardenListHeaderTextWithSupportingText.kt (+0 -61)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/type/Typography.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendContent.kt (+1 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingContent.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+8 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeScreen.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+6 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+15 -23)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+16 -22)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeScreenTest.kt (+9 -29)

📄 Description

🎟️ Tracking

PM-14200

📔 Objective

This PR updates all the eyebrows in the app.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4181 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-14200-app-eyebrows` --- ### 📝 Commits (1) - [`606740a`](https://github.com/bitwarden/android/commit/606740a8a3da03517deb531ce7d3e8e130d1f613) PM-14200: Update the eyebrows throughout the app ### 📊 Changes **11 files changed** (+79 additions, -164 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/header/BitwardenListHeaderText.kt` (+17 -6) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/header/BitwardenListHeaderTextWithSupportingText.kt` (+0 -61) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/type/Typography.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendContent.kt` (+1 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingContent.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+8 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeScreen.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+6 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+15 -23) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+16 -22) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeScreenTest.kt` (+9 -29) </details> ### 📄 Description ## 🎟️ Tracking [PM-14200](https://bitwarden.atlassian.net/browse/PM-14200) ## 📔 Objective This PR updates all the eyebrows in the app. ## 📸 Screenshots | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/d315cc45-b39d-457d-88bf-8346fb0b725e" width="300" /> | <img src="https://github.com/user-attachments/assets/7bf67b0f-25b1-48ad-a68d-3642737cf642" width="300" /> | | <img src="https://github.com/user-attachments/assets/8237b7d0-ecbb-4524-b5a2-a971fd24ab35" width="300" /> | <img src="https://github.com/user-attachments/assets/5086b7e8-f46a-4a26-bb71-6715d2925103" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-14200]: https://bitwarden.atlassian.net/browse/PM-14200?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?