github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4180] [MERGED] PM-13988 observe changes to unlock status on settings screen #4754

New Issue
Closed
opened 2025-11-26 23:49:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4180
Author: @dseverns-livefront
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @dseverns-livefront

Base: main ← Head: observe-lock-status-changes

📝 Commits (2)

  • a32d27e PM-13988 observe changes to unlock status on settings screen
  • 5563c88 ?:

📊 Changes

9 files changed (+246 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSource.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceImpl.kt (+26 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt (+62 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceTest.kt (+31 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/util/FakeAuthDiskSource.kt (+27 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+36 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt (+26 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13988

📔 Objective

  • Fix issue where the account lock values were not updating when changed through the "Setup unlock" screen after clicking the action card.

📸 Screenshots

Before:

https://github.com/user-attachments/assets/0c500fb7-f305-4ab1-97b6-40db505e1078

After:

https://github.com/user-attachments/assets/5e5cfb4b-39e2-4e4d-bfb5-f311046b5600

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4180 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `observe-lock-status-changes` --- ### 📝 Commits (2) - [`a32d27e`](https://github.com/bitwarden/android/commit/a32d27ec50a475bfe71d73ca8aa841f94c1897a1) PM-13988 observe changes to unlock status on settings screen - [`5563c88`](https://github.com/bitwarden/android/commit/5563c88c28681af8a9957fd3a875be818cd99430) ?: ### 📊 Changes **9 files changed** (+246 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSource.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceImpl.kt` (+26 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt` (+62 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/AuthDiskSourceTest.kt` (+31 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/util/FakeAuthDiskSource.kt` (+27 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+36 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt` (+26 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13988 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Fix issue where the account lock values were not updating when changed through the "Setup unlock" screen after clicking the action card. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots Before: https://github.com/user-attachments/assets/0c500fb7-f305-4ab1-97b6-40db505e1078 After: https://github.com/user-attachments/assets/5e5cfb4b-39e2-4e4d-bfb5-f311046b5600 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4754
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?