github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4177] [MERGED] [PM-12406] Introduce new endpoint and replace SSO details response flow #4751

New Issue
Closed
opened 2025-11-26 23:49:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4177
Author: @andrebispo5
Created: 10/28/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @andrebispo5

Base: main ← Head: pm-12406/domain-verified-endpoint

📝 Commits (10+)

📊 Changes

18 files changed (+490 additions, -12 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/UnauthenticatedOrganizationApi.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/OrganizationDomainSsoDetailsResponseJson.kt (+12 -2)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/VerifiedOrganizationDomainSsoDetailsRequest.kt (+14 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/VerifiedOrganizationDomainSsoDetailsResponse.kt (+35 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/OrganizationService.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/OrganizationServiceImpl.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+8 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/OrganizationDomainSsoDetailsResult.kt (+4 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/VerifiedOrganizationDomainSsoDetailsResult.kt (+22 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt (+81 -7)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+2 -0)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/network/service/OrganizationServiceTest.kt (+59 -3)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+46 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModelTest.kt (+148 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+2 -0)

📄 Description

🎟️ Tracking

[PM-12406 Introduce new endpoint and replace SSO details response flow](https://bitwarden.atlassian.net/browse/PM-12406)

📔 Objective

In order to align the back-end contract with the front-end expectations, add a net-new GET verified domains flow.
We will keep the original SSO details flow in place, this new implementation will be behind a remote feature flag.

📸 Screenshots

https://github.com/user-attachments/assets/8ce7753e-2535-4ad1-8cdb-aa37270c0635

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4177 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-12406/domain-verified-endpoint` --- ### 📝 Commits (10+) - [`9757160`](https://github.com/bitwarden/android/commit/97571601ff5dca3f64dfe41687d6a5b7ce69c3e1) [PM-12406] Add unauthenticated verified org domains endpoint setup - [`ea16cd9`](https://github.com/bitwarden/android/commit/ea16cd964d8bbce19f5400222c5f09f9cefee581) [PM-12406] Add verified organization domain details service call to OrganizationService - [`4768824`](https://github.com/bitwarden/android/commit/476882474902a6b37fafd07bba928d00f3ee51e6) [PM-12406] Add feature flag for the new verified SSO domain endpoint - [`467ccde`](https://github.com/bitwarden/android/commit/467ccde07c9c9f08a145d70bf28c0fa6aa291903) [PM-12406] Add missing feature flag information - [`74efb7e`](https://github.com/bitwarden/android/commit/74efb7e30da70f8b6288e1737fddcd5867800c2b) [PM-12406] Add verified organization domain details call to AuthRepository - [`689a93b`](https://github.com/bitwarden/android/commit/689a93b06c8e53e152dfaecbd09aa1d0034fc4ea) [PM-12406] Add verified date to OrganizationDomainSsoDetailsResponseJson - [`23ede75`](https://github.com/bitwarden/android/commit/23ede756d70509fb3d6ea667a6a7bde68207598f) [PM-12406] Add verifiedDate to SSO login checks - [`c75cf4f`](https://github.com/bitwarden/android/commit/c75cf4fa487bc322fa67f2097834bf72276ca83e) [PM-12406] handle verified organization domain sso details within the SSO Login flow. Feature flag also used. - [`4ad36c7`](https://github.com/bitwarden/android/commit/4ad36c79f688cba469dbb6842fa9c855cf25d314) [PM-12406] Add no verified date test. - [`23de960`](https://github.com/bitwarden/android/commit/23de960ace72064570fe7678b97ec7dc12002a88) [PM-12406] Add verified date property where it's missing ### 📊 Changes **18 files changed** (+490 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/UnauthenticatedOrganizationApi.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/OrganizationDomainSsoDetailsResponseJson.kt` (+12 -2) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/VerifiedOrganizationDomainSsoDetailsRequest.kt` (+14 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/VerifiedOrganizationDomainSsoDetailsResponse.kt` (+35 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/OrganizationService.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/OrganizationServiceImpl.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+8 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/OrganizationDomainSsoDetailsResult.kt` (+4 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/VerifiedOrganizationDomainSsoDetailsResult.kt` (+22 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt` (+81 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+2 -0) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/network/service/OrganizationServiceTest.kt` (+59 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+46 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModelTest.kt` (+148 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> [[PM-12406] Introduce new endpoint and replace SSO details response flow](https://bitwarden.atlassian.net/browse/PM-12406) ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> In order to align the back-end contract with the front-end expectations, add a net-new GET verified domains flow. We will keep the original SSO details flow in place, this new implementation will be behind a remote feature flag. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> https://github.com/user-attachments/assets/8ce7753e-2535-4ad1-8cdb-aa37270c0635 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-12406]: https://bitwarden.atlassian.net/browse/PM-12406?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4751
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?