github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4170] [MERGED] PM-14184: Update the switch thoughout the app #4745

New Issue
Closed
opened 2025-11-26 23:49:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4170
Author: @david-livefront
Created: 10/25/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @david-livefront

Base: main ← Head: update-switches

📝 Commits (1)

  • 5c0fc06 Update the switch thoughout the app

📊 Changes

22 files changed (+158 additions, -343 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenSwitch.kt (+111 -66)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenSwitchWithActions.kt (+0 -89)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithBiometricsSwitch.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithPinSwitch.kt (+1 -1)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenWideSwitch.kt (+0 -137)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt (+6 -6)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherScreen.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+10 -10)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/components/CollectionItemSelector.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCardItems.kt (+1 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomField.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditIdentityItems.kt (+1 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+1 -2)

...and 2 more files

📄 Description

🎟️ Tracking

PM-14184

📔 Objective

This PR updates the switch throughout the app to match the v3 designs.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4170 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/25/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-switches` --- ### 📝 Commits (1) - [`5c0fc06`](https://github.com/bitwarden/android/commit/5c0fc067a93e5d892ebe97de7817241473dc44f8) Update the switch thoughout the app ### 📊 Changes **22 files changed** (+158 additions, -343 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenSwitch.kt` (+111 -66) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenSwitchWithActions.kt` (+0 -89) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithBiometricsSwitch.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithPinSwitch.kt` (+1 -1) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenWideSwitch.kt` (+0 -137) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt` (+6 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherScreen.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+10 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/components/CollectionItemSelector.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCardItems.kt` (+1 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomField.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditIdentityItems.kt` (+1 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+1 -2) _...and 2 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-14184](https://bitwarden.atlassian.net/browse/PM-14184) ## 📔 Objective This PR updates the switch throughout the app to match the v3 designs. ## 📸 Screenshots |Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/4065d98c-1f56-4600-b12f-d5aeab27e852" width="300" /> | <img src="https://github.com/user-attachments/assets/4302505c-d5db-4ffa-ba7a-67bf7feca702" width="300" /> | | <img src="https://github.com/user-attachments/assets/b59e36fc-a5e9-413e-b4f6-989c78c3cb9b" width="300" /> | <img src="https://github.com/user-attachments/assets/86db073e-8c80-45eb-9f6c-2b8bbc9320bd" width="300" /> | | <img src="https://github.com/user-attachments/assets/41bf74a0-f3b7-4c4f-8c13-9361b4c8d8b9" width="300" /> | <img src="https://github.com/user-attachments/assets/00d202ea-3233-47fd-a4d2-73f3eb36a66b" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-14184]: https://bitwarden.atlassian.net/browse/PM-14184?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4745
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?